From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48494) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YrphG-0002Jy-2J for qemu-devel@nongnu.org; Mon, 11 May 2015 11:32:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YrphF-0004zu-2R for qemu-devel@nongnu.org; Mon, 11 May 2015 11:32:45 -0400 Message-ID: <5550CB95.8090705@redhat.com> Date: Mon, 11 May 2015 09:32:37 -0600 From: Eric Blake MIME-Version: 1.0 References: <1430746944-27347-1-git-send-email-den@openvz.org> <1430746944-27347-3-git-send-email-den@openvz.org> <20150511145437.GJ16270@stefanha-thinkpad.redhat.com> In-Reply-To: <20150511145437.GJ16270@stefanha-thinkpad.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="DtWOt6OV53QBenTG40XPWDf7QwMKrcvh4" Subject: Re: [Qemu-devel] [Qemu-block] [PATCH 2/2] block: align bounce buffers to page List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , "Denis V. Lunev" Cc: Paolo Bonzini , qemu-block@nongnu.org, qemu-devel@nongnu.org, Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --DtWOt6OV53QBenTG40XPWDf7QwMKrcvh4 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/11/2015 08:54 AM, Stefan Hajnoczi wrote: > On Mon, May 04, 2015 at 04:42:24PM +0300, Denis V. Lunev wrote: >> @@ -726,7 +727,8 @@ static void raw_refresh_limits(BlockDriverState *b= s, Error **errp) >> =20 >> raw_probe_alignment(bs, s->fd, errp); >> bs->bl.min_mem_alignment =3D s->buf_align; >> - bs->bl.opt_mem_alignment =3D s->buf_align; >> + if (bs->bl.min_mem_alignment > bs->bl.opt_mem_alignment) >> + bs->bl.opt_mem_alignment =3D bs->bl.min_mem_alignment; >=20 > QEMU coding style uses {} even when the if statement body is only one > line. scripts/checkpatch.pl helps you check for this and other style issues. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --DtWOt6OV53QBenTG40XPWDf7QwMKrcvh4 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVUMuWAAoJEKeha0olJ0Nq6WAH/jabfv87QF1By3csByqJlDGP /C+OWJp6q/HVsnPteNnA5mXYQuINS4XVoMHwQpd9/MUVCDhsG/4HJE9Z7zm+WsBy M6lwPvqEmM4+9VTmjz1TYUkyJAvFx6SBR427EoCaOF6Z/ua87zZ1Q0ZCCAafGrQX de623g2yNnimCJomO83goXne2ssbdCbVg0KPC6Nvu+CnB5ZN9XrHy0Oc8lf40i0h einReZKa3HMDJ3XpZ/qfFqiwztypA9tfqUDQIkfSSGWhjT2SJY9567Te7jHJSigi rUhpiGEBhlwMEHRsNXbCdxByGHw84FQKZoV14axJccPYg/t57YL7n4DFGr5+3tE= =ivzT -----END PGP SIGNATURE----- --DtWOt6OV53QBenTG40XPWDf7QwMKrcvh4--