From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50508)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den@openvz.org>) id 1Yrpp0-0007Dh-MR
	for qemu-devel@nongnu.org; Mon, 11 May 2015 11:40:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <den@openvz.org>) id 1Yrpox-0007lu-4P
	for qemu-devel@nongnu.org; Mon, 11 May 2015 11:40:46 -0400
Received: from relay.parallels.com ([195.214.232.42]:35329)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den@openvz.org>) id 1Yrpow-0007lB-JX
	for qemu-devel@nongnu.org; Mon, 11 May 2015 11:40:42 -0400
Message-ID: <5550CD63.809@openvz.org>
Date: Mon, 11 May 2015 18:40:19 +0300
From: "Denis V. Lunev" <den@openvz.org>
MIME-Version: 1.0
References: <1430746944-27347-1-git-send-email-den@openvz.org>	<1430746944-27347-3-git-send-email-den@openvz.org>
	<20150511145437.GJ16270@stefanha-thinkpad.redhat.com>
	<5550CB95.8090705@redhat.com>
In-Reply-To: <5550CB95.8090705@redhat.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH 2/2] block: align bounce
 buffers to page
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>, Stefan Hajnoczi <stefanha@gmail.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-block@nongnu.org, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>

On 11/05/15 18:32, Eric Blake wrote:
> On 05/11/2015 08:54 AM, Stefan Hajnoczi wrote:
>> On Mon, May 04, 2015 at 04:42:24PM +0300, Denis V. Lunev wrote:
>>> @@ -726,7 +727,8 @@ static void raw_refresh_limits(BlockDriverState *bs, Error **errp)
>>>   
>>>       raw_probe_alignment(bs, s->fd, errp);
>>>       bs->bl.min_mem_alignment = s->buf_align;
>>> -    bs->bl.opt_mem_alignment = s->buf_align;
>>> +    if (bs->bl.min_mem_alignment > bs->bl.opt_mem_alignment)
>>> +        bs->bl.opt_mem_alignment = bs->bl.min_mem_alignment;
>> QEMU coding style uses {} even when the if statement body is only one
>> line.
> scripts/checkpatch.pl helps you check for this and other style issues.
>
yep, I have forgotten to run this before sending this time :(