From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53353)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Yrpyp-0007Ek-RQ
	for qemu-devel@nongnu.org; Mon, 11 May 2015 11:50:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Yrpyl-0002vS-DH
	for qemu-devel@nongnu.org; Mon, 11 May 2015 11:50:55 -0400
Received: from mail-qk0-x22a.google.com ([2607:f8b0:400d:c09::22a]:33747)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Yrpyk-0002vH-Tz
	for qemu-devel@nongnu.org; Mon, 11 May 2015 11:50:51 -0400
Received: by qkx62 with SMTP id 62so89563756qkx.0
	for <qemu-devel@nongnu.org>; Mon, 11 May 2015 08:50:50 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <5550CFD5.7070501@twiddle.net>
Date: Mon, 11 May 2015 08:50:45 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <cover.1431200693.git.crosthwaite.peter@gmail.com>
	<568911201d01acf373f834af21c5d193dd6d8f2f.1431200693.git.crosthwaite.peter@gmail.com>
	<5550C0BA.9000700@redhat.com>
In-Reply-To: <5550C0BA.9000700@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 2/7] disas: QOMify target specific setup
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, Peter Crosthwaite <crosthwaitepeter@gmail.com>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, edgari@xilinx.com, claudio.fontana@huawei.com, edgar.iglesias@gmail.com

On 05/11/2015 07:46 AM, Paolo Bonzini wrote:
> 
> 
> On 09/05/2015 22:11, Peter Crosthwaite wrote:
>> @@ -198,6 +199,8 @@ static int print_insn_od_target(bfd_vma pc, disassemble_info *info)
>>  void target_disas(FILE *out, CPUArchState *env, target_ulong code,
>>                    target_ulong size, int flags)
>>  {
>> +    CPUState *cpu = ENV_GET_CPU(env);
>> +    CPUClass *cc = CPU_GET_CLASS(cpu);
>>      target_ulong pc;
>>      int count;
>>      CPUDebug s;
>> @@ -215,6 +218,11 @@ void target_disas(FILE *out, CPUArchState *env, target_ulong code,
>>  #else
>>      s.info.endian = BFD_ENDIAN_LITTLE;
>>  #endif
>> +
>> +    if (cc->disas_set_info) {
>> +        cc->disas_set_info(cpu, &s.info);
>> +    }
>> +
>>  #if defined(TARGET_I386)
> 
> Perhaps pass down the flags too?

The hook is allowing us to ditch the flags.  See 4/7 and 7/7 for arm and cris
portions that do exactly that.


r~