From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53480)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1YrpzL-00085W-0C
	for qemu-devel@nongnu.org; Mon, 11 May 2015 11:51:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1YrpzK-00030y-2k
	for qemu-devel@nongnu.org; Mon, 11 May 2015 11:51:26 -0400
Received: from mail-qc0-x232.google.com ([2607:f8b0:400d:c01::232]:36174)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1YrpzJ-00030n-V0
	for qemu-devel@nongnu.org; Mon, 11 May 2015 11:51:26 -0400
Received: by qcbgy10 with SMTP id gy10so71023333qcb.3
	for <qemu-devel@nongnu.org>; Mon, 11 May 2015 08:51:25 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <5550CFF9.7040705@twiddle.net>
Date: Mon, 11 May 2015 08:51:21 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <cover.1431200693.git.crosthwaite.peter@gmail.com>
	<812946309c5e1e6fbf404cdd5f6c312d789545a5.1431200693.git.crosthwaite.peter@gmail.com>
In-Reply-To: <812946309c5e1e6fbf404cdd5f6c312d789545a5.1431200693.git.crosthwaite.peter@gmail.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 1/7] disas: Add print_insn to
	disassemble info
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Crosthwaite <crosthwaitepeter@gmail.com>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, edgari@xilinx.com, claudio.fontana@huawei.com, edgar.iglesias@gmail.com

On 05/09/2015 01:11 PM, Peter Crosthwaite wrote:
> Add the print_insn pointer to the disassemble info structure. This is
> to prepare for QOMification support, where a QOM CPU hook function will
> be responsible for setting the print_insn function. Add this function
> to the existing struct to consolidate such that only the one struct
> needs to be passed to the new QOM API.
> 
> Signed-off-by: Peter Crosthwaite <crosthwaite.peter@gmail.com>
> ---
>  disas.c             | 68 ++++++++++++++++++++++++++---------------------------
>  include/disas/bfd.h |  6 +++++
>  2 files changed, 39 insertions(+), 35 deletions(-)

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~