From: Richard Henderson <rth@twiddle.net>
To: Peter Crosthwaite <crosthwaitepeter@gmail.com>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, edgari@xilinx.com,
claudio.fontana@huawei.com, edgar.iglesias@gmail.com
Subject: Re: [Qemu-devel] [PATCH v2 3/7] disas: arm-a64: Make printfer and stream variable
Date: Mon, 11 May 2015 08:57:33 -0700 [thread overview]
Message-ID: <5550D16D.8000509@twiddle.net> (raw)
In-Reply-To: <7a8d40b3ecde7b93b23125ee05437a84f0946a9e.1431200693.git.crosthwaite.peter@gmail.com>
On 05/09/2015 01:11 PM, Peter Crosthwaite wrote:
> class QEMUDisassembler : public Disassembler {
> public:
> - explicit QEMUDisassembler(FILE *stream) : stream_(stream) { }
> + QEMUDisassembler() {
> + printf_ = NULL;
> + stream_ = NULL;
> + }
As a nit, I would have written this
QEMUDisassembler(FILE *stream) : stream_(NULL), printf_(NULL) { }
but the difference is unlikely to matter here.
Reviewed-by: Richard Henderson <rth@twiddle.net>
r~
next prev parent reply other threads:[~2015-05-11 15:57 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-09 20:11 [Qemu-devel] [PATCH v2 0/7] Unify and QOMify (target|monitor)_disas Peter Crosthwaite
2015-05-09 20:11 ` [Qemu-devel] [PATCH v2 1/7] disas: Add print_insn to disassemble info Peter Crosthwaite
2015-05-11 15:51 ` Richard Henderson
2015-05-09 20:11 ` [Qemu-devel] [PATCH v2 2/7] disas: QOMify target specific setup Peter Crosthwaite
2015-05-11 14:46 ` Paolo Bonzini
2015-05-11 15:50 ` Richard Henderson
2015-05-11 15:51 ` Richard Henderson
2015-05-09 20:11 ` [Qemu-devel] [PATCH v2 3/7] disas: arm-a64: Make printfer and stream variable Peter Crosthwaite
2015-05-11 15:57 ` Richard Henderson [this message]
2015-05-24 21:28 ` Peter Crosthwaite
2015-05-09 20:11 ` [Qemu-devel] [PATCH v2 4/7] disas: arm: QOMify target specific disas setup Peter Crosthwaite
2015-05-18 16:31 ` Peter Maydell
2015-05-24 21:42 ` Peter Crosthwaite
2015-05-09 20:11 ` [Qemu-devel] [PATCH v2 5/7] disas: microblaze: " Peter Crosthwaite
2015-05-09 20:11 ` [Qemu-devel] [PATCH v2 6/7] disas: cris: Fix 0 buffer length case Peter Crosthwaite
2015-05-09 20:11 ` [Qemu-devel] [PATCH v2 7/7] disas: cris: QOMify target specific disas setup Peter Crosthwaite
2015-05-15 4:52 ` [Qemu-devel] [PATCH v2 0/7] Unify and QOMify (target|monitor)_disas Peter Crosthwaite
2015-05-15 13:33 ` Richard Henderson
2015-05-15 17:02 ` Peter Crosthwaite
2015-05-15 21:01 ` Peter Crosthwaite
2015-05-15 23:13 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5550D16D.8000509@twiddle.net \
--to=rth@twiddle.net \
--cc=claudio.fontana@huawei.com \
--cc=crosthwaitepeter@gmail.com \
--cc=edgar.iglesias@gmail.com \
--cc=edgari@xilinx.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).