From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55473)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Yrq5M-0004GL-Sk
	for qemu-devel@nongnu.org; Mon, 11 May 2015 11:57:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Yrq5J-0005LT-Kn
	for qemu-devel@nongnu.org; Mon, 11 May 2015 11:57:40 -0400
Received: from mail-qk0-x235.google.com ([2607:f8b0:400d:c09::235]:33323)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Yrq5J-0005Kx-HA
	for qemu-devel@nongnu.org; Mon, 11 May 2015 11:57:37 -0400
Received: by qkx62 with SMTP id 62so89712281qkx.0
	for <qemu-devel@nongnu.org>; Mon, 11 May 2015 08:57:37 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <5550D16D.8000509@twiddle.net>
Date: Mon, 11 May 2015 08:57:33 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <cover.1431200693.git.crosthwaite.peter@gmail.com>
	<7a8d40b3ecde7b93b23125ee05437a84f0946a9e.1431200693.git.crosthwaite.peter@gmail.com>
In-Reply-To: <7a8d40b3ecde7b93b23125ee05437a84f0946a9e.1431200693.git.crosthwaite.peter@gmail.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 3/7] disas: arm-a64: Make printfer and
	stream variable
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Crosthwaite <crosthwaitepeter@gmail.com>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, edgari@xilinx.com, claudio.fontana@huawei.com, edgar.iglesias@gmail.com

On 05/09/2015 01:11 PM, Peter Crosthwaite wrote:
>  class QEMUDisassembler : public Disassembler {
>  public:
> -    explicit QEMUDisassembler(FILE *stream) : stream_(stream) { }
> +    QEMUDisassembler() {
> +        printf_ = NULL;
> +        stream_ = NULL;
> +    }

As a nit, I would have written this

  QEMUDisassembler(FILE *stream) : stream_(NULL), printf_(NULL) { }

but the difference is unlikely to matter here.

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~