From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58555) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YrqBx-0004x9-3g for qemu-devel@nongnu.org; Mon, 11 May 2015 12:04:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YrqBw-0007rJ-Al for qemu-devel@nongnu.org; Mon, 11 May 2015 12:04:29 -0400 Message-ID: <5550D302.90004@redhat.com> Date: Mon, 11 May 2015 18:04:18 +0200 From: Max Reitz MIME-Version: 1.0 References: <1431105726-3682-1-git-send-email-kwolf@redhat.com> <1431105726-3682-11-git-send-email-kwolf@redhat.com> In-Reply-To: <1431105726-3682-11-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 10/34] block: Fix reopen flag inheritance List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: armbru@redhat.com, qemu-devel@nongnu.org On 08.05.2015 19:21, Kevin Wolf wrote: > When reopening an image, the block layer already takes care to reopen > bs->file as well with recalculated inherited flags. The same must happen > for any other child (most notably missing before this patch: backing > files). > > If bs->file (or any other child) didn't originally inherit from bs, e.g. > because it was created separately and then only referenced, it must not > inherit flags on reopen either, so check the inherited_from field before > propagation the reopen down. > > VMDK already reopened its extents manually; this code can now be > dropped. > > Signed-off-by: Kevin Wolf > --- > block.c | 13 +++++++++++-- > block/vmdk.c | 28 ++-------------------------- > 2 files changed, 13 insertions(+), 28 deletions(-) Reviewed-by: Max Reitz