qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, mrezanin@redhat.com
Cc: thuth@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCHv2] parallel: Allow to disable CONFIG_PARALLEL
Date: Mon, 11 May 2015 18:20:42 +0200	[thread overview]
Message-ID: <5550D6DA.1090001@redhat.com> (raw)
In-Reply-To: <87lhgvb17e.fsf@blackfin.pond.sub.org>



On 11/05/2015 17:09, Markus Armbruster wrote:
> Fails to link if I disable CONFIG_PARALLEL in
> default-configs/mips-softmmu.mak:
> 
>       LINK  mips-softmmu/qemu-system-mips
>     hw/mips/mips_jazz.o: In function `mips_jazz_init':
>     /home/armbru/work/qemu/hw/mips/mips_jazz.c:323: undefined reference to `parallel_mm_init'
>     collect2: error: ld returned 1 exit status
>     make[1]: *** [qemu-system-mips] Error 1
> 
> To fix that, you'd need to stub out parallel_mm_init(), too.

I would ignore that.  parallel_mm_init isn't even qdev-ified, and
qdevification would fix that problem too.

Paolo

      reply	other threads:[~2015-05-11 16:20 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-11  5:38 [Qemu-devel] [PATCHv2] parallel: Allow to disable CONFIG_PARALLEL mrezanin
2015-05-11  6:46 ` Markus Armbruster
2015-05-11  7:02   ` Miroslav Rezanina
2015-05-11 15:10     ` Markus Armbruster
2015-05-11  8:40 ` Paolo Bonzini
2015-05-11  9:36   ` Miroslav Rezanina
2015-05-11 10:11     ` Paolo Bonzini
2015-05-11 15:52       ` Markus Armbruster
2015-05-11 16:01         ` Paolo Bonzini
2015-05-11 16:34         ` Peter Maydell
2015-05-11 15:09 ` Markus Armbruster
2015-05-11 16:20   ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5550D6DA.1090001@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=armbru@redhat.com \
    --cc=mrezanin@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).