From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34448) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YrqRn-0006XX-Sb for qemu-devel@nongnu.org; Mon, 11 May 2015 12:20:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YrqRk-0004wZ-0x for qemu-devel@nongnu.org; Mon, 11 May 2015 12:20:51 -0400 Received: from mail-wi0-x229.google.com ([2a00:1450:400c:c05::229]:33415) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YrqRj-0004w4-Oc for qemu-devel@nongnu.org; Mon, 11 May 2015 12:20:47 -0400 Received: by wief7 with SMTP id f7so90176615wie.0 for ; Mon, 11 May 2015 09:20:46 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <5550D6DA.1090001@redhat.com> Date: Mon, 11 May 2015 18:20:42 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1431322734-12520-1-git-send-email-mrezanin@redhat.com> <87lhgvb17e.fsf@blackfin.pond.sub.org> In-Reply-To: <87lhgvb17e.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCHv2] parallel: Allow to disable CONFIG_PARALLEL List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , mrezanin@redhat.com Cc: thuth@redhat.com, qemu-devel@nongnu.org On 11/05/2015 17:09, Markus Armbruster wrote: > Fails to link if I disable CONFIG_PARALLEL in > default-configs/mips-softmmu.mak: > > LINK mips-softmmu/qemu-system-mips > hw/mips/mips_jazz.o: In function `mips_jazz_init': > /home/armbru/work/qemu/hw/mips/mips_jazz.c:323: undefined reference to `parallel_mm_init' > collect2: error: ld returned 1 exit status > make[1]: *** [qemu-system-mips] Error 1 > > To fix that, you'd need to stub out parallel_mm_init(), too. I would ignore that. parallel_mm_init isn't even qdev-ified, and qdevification would fix that problem too. Paolo