From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57065) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YrtrA-0002W9-O9 for qemu-devel@nongnu.org; Mon, 11 May 2015 15:59:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yrtr7-0002iZ-IG for qemu-devel@nongnu.org; Mon, 11 May 2015 15:59:16 -0400 Received: from mail-oi0-x235.google.com ([2607:f8b0:4003:c06::235]:36557) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yrtr7-0002i1-DH for qemu-devel@nongnu.org; Mon, 11 May 2015 15:59:13 -0400 Received: by oift201 with SMTP id t201so113641330oif.3 for ; Mon, 11 May 2015 12:59:12 -0700 (PDT) Sender: Corey Minyard Message-ID: <555109F6.9020108@acm.org> Date: Mon, 11 May 2015 14:58:46 -0500 From: Corey Minyard MIME-Version: 1.0 References: <1429829878-26862-1-git-send-email-minyard@acm.org> <1429829878-26862-3-git-send-email-minyard@acm.org> <20150426105502-mutt-send-email-mst@redhat.com> <554D2791.6070401@acm.org> <5550E641.2060108@suse.de> <5551063B.2030708@redhat.com> In-Reply-To: <5551063B.2030708@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 02/17] ipmi: Add a PC ISA type structure Reply-To: minyard@acm.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , =?windows-1252?Q?Andreas_F=E4r?= =?windows-1252?Q?ber?= , "Michael S. Tsirkin" Cc: Corey Minyard , qemu-devel@nongnu.org On 05/11/2015 02:42 PM, Paolo Bonzini wrote: > > On 11/05/2015 19:26, Andreas Färber wrote: >> Another problem is that you're using object_new() in realize at all, >> which means that it's too late for any management interface to tweak >> properties on the new device. One possible solution would be to create >> the object in a property setter, before realizing the object. Did you >> look at how some of the other backends are implemented, such as rng? > Note that this is not exactly a backend. It's a different guest-visible > I/O interface. But there are no properties on the interface, so it's > okay to create it at realize time. > > Paolo I've debated this in my mind since I've been learning more about qemu. Some of the bmc properties are being passed in to the interface and passed on to the bmc. Plus some IPMI systems have multiple interfaces that point to the same bmc. It might be best to have the user create a bmc device then tie an interface device to it. If I do this, what is the acceptable way to look up another object this way? I hunted a bit and didn't come up with anything clean. Thanks, -corey