From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58083)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Yrw8F-0003dU-MR
	for qemu-devel@nongnu.org; Mon, 11 May 2015 18:25:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Yrw8C-0005lw-Cw
	for qemu-devel@nongnu.org; Mon, 11 May 2015 18:25:03 -0400
Received: from cantor2.suse.de ([195.135.220.15]:59007 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Yrw8C-0005lq-68
	for qemu-devel@nongnu.org; Mon, 11 May 2015 18:25:00 -0400
Message-ID: <55512C38.3010207@suse.de>
Date: Tue, 12 May 2015 00:24:56 +0200
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1430981715-31465-1-git-send-email-famz@redhat.com>
In-Reply-To: <1430981715-31465-1-git-send-email-famz@redhat.com>
Content-Type: text/plain; charset=iso-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v2] rules.mak: Force CFLAGS for all objects
 in DSO
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>, Paolo Bonzini <pbonzini@redhat.com>, Michael Tokarev <mjt@tls.msk.ru>, agraf@suse.de, Stefan Weil <sw@weilnetz.de>

Am 07.05.2015 um 08:55 schrieb Fam Zheng:
> Because of the trick of process-archive-undefs, all .mo objects, even
> with --enable-modules, are dependencies of executables.
>=20
> This breaks CFLAGS propogation because the compiling of module object
> will happen too early before building for DSO.
>=20
> With GCC 5, the linking would fail because .o doesn't have -fPIC. Also,
> BUILD_DSO will be missed. (module-common.o will have it, so the stamp
> symbol was still liked in .so).

Did you mean "linked"?

Cheers,
Andreas

>=20
> Fix the problem by forcing the CFLAGS on individual .o-cflags during
> unnest-vars.
>=20
> Reported-by: Alexander Graf <agraf@suse.de>
> Signed-off-by: Fam Zheng <famz@redhat.com>
>=20
> ---
>=20
> v2: Simplify as Paolo suggested, while keeping the CFLAGS of
> module-common.o
> ---
>  rules.mak | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>=20
> diff --git a/rules.mak b/rules.mak
> index 3a05627..aec27f8 100644
> --- a/rules.mak
> +++ b/rules.mak
> @@ -102,7 +102,8 @@ endif
>  %.o: %.dtrace
>  	$(call quiet-command,dtrace -o $@ -G -s $<, "  GEN   $(TARGET_DIR)$@"=
)
> =20
> -%$(DSOSUF): CFLAGS +=3D -fPIC -DBUILD_DSO
> +DSO_OBJ_CFLAGS :=3D -fPIC -DBUILD_DSO
> +module-common.o: CFLAGS +=3D $(DSO_OBJ_CFLAGS)
>  %$(DSOSUF): LDFLAGS +=3D $(LDFLAGS_SHARED)
>  %$(DSOSUF): %.mo
>  	$(call LINK,$^)
> @@ -351,6 +352,7 @@ define unnest-vars
>          # For non-module build, add -m to -y
>          $(if $(CONFIG_MODULES),
>               $(foreach o,$($v),
> +                   $(eval $($o-objs): CFLAGS +=3D $(DSO_OBJ_CFLAGS))
>                     $(eval $o: $($o-objs)))
>               $(eval $(patsubst %-m,%-y,$v) +=3D $($v))
>               $(eval modules: $($v:%.mo=3D%$(DSOSUF))),
>=20


--=20
SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Felix Imend=F6rffer, Jane Smithard, Dilip Upmanyu, Graham Norton; HRB
21284 (AG N=FCrnberg)