From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37172) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ys6M1-0004jZ-Bq for qemu-devel@nongnu.org; Tue, 12 May 2015 05:20:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ys6Ly-0006nP-5h for qemu-devel@nongnu.org; Tue, 12 May 2015 05:19:57 -0400 Received: from mail-wi0-x234.google.com ([2a00:1450:400c:c05::234]:37502) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ys6Lx-0006mk-VY for qemu-devel@nongnu.org; Tue, 12 May 2015 05:19:54 -0400 Received: by widdi4 with SMTP id di4so6073563wid.0 for ; Tue, 12 May 2015 02:19:53 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <5551A785.60300@redhat.com> Date: Tue, 12 May 2015 09:11:01 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <5549C424.3080203@msgid.tls.msk.ru> <554B024B.90101@msgid.tls.msk.ru> <554B0A67.5050107@msgid.tls.msk.ru> <554B3188.30308@msgid.tls.msk.ru> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] Bug report - Windows XP guest failure List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite , Michael Tokarev Cc: G 3 , qemu-devel qemu-devel On 12/05/2015 03:05, Peter Crosthwaite wrote: > On Thu, May 7, 2015 at 2:34 AM, Michael Tokarev wrote: >> 07.05.2015 09:47, Michael Tokarev wrote: >>> 07.05.2015 09:12, Michael Tokarev wrote: >>>> 07.05.2015 04:11, G 3 wrote: >>>>> Did you boot Windows XP to the desktop? I have tested Windows 95, Windows 2000, and Windows XP. All of them fail to boot to the desktop. >>>> >>>> Yes, booted to desktop and did some minimal work in there, >>>> installnig one update or two. >>>> >>>>> Command used: >>>>> ./i386-softmmu/qemu-system-i386 -boot c -hda "Windows XP Hard Drive.img" >>>> >>>> Aha. You run without kvm, in tcg mode. I don't usually do that, >>>> lemme try... >>> >>> Ok, I can reproduce this, winXP BSODs on boot in tcg mode. >>> Git bisect points to this: >>> >>> commit 23820dbfc79d1c9dce090b4c555994f2bb6a69b3 >>> Author: Peter Crosthwaite >>> Date: Mon Mar 16 22:35:54 2015 -0700 >>> >>> exec: Respect as_translate_internal length clamp >>> >>> address_space_translate_internal will clamp the *plen length argument >>> based on the size of the memory region being queried. The iommu walker >>> logic in addresss_space_translate was ignoring this by discarding the >>> post fn call value of *plen. Fix by just always using *plen as the >>> length argument throughout the fn, removing the len local variable. >>> >>> This fixes a bootloader bug when a single elf section spans multiple >>> QEMU memory regions. >>> >>> Signed-off-by: Peter Crosthwaite >>> Message-Id: <1426570554-15940-1-git-send-email-peter.crosthwaite@xilinx.com> >>> Signed-off-by: Paolo Bonzini >> >> This winXP BSOD happens on x86_64 target too. Reverting the >> above commit from git master fixes the BSOD. >> > > Any useful info about IO addresses on that BSOD? The last issue with > this patch was IOPort code relying on the bug that this patch fixed. > This could be similar and if we can track the failure to a particular > address we can fix properly rather than another revert of that patch. Yes, it's on my todo list. Paolo