From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44057) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YsAES-000886-Nb for qemu-devel@nongnu.org; Tue, 12 May 2015 09:28:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YsA9K-0001G9-MW for qemu-devel@nongnu.org; Tue, 12 May 2015 09:23:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57108) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YsA9K-0001Fz-HU for qemu-devel@nongnu.org; Tue, 12 May 2015 09:23:06 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id B62008EA53 for ; Tue, 12 May 2015 13:23:05 +0000 (UTC) Message-ID: <5551FEB2.5000005@redhat.com> Date: Tue, 12 May 2015 15:22:58 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCHv3 2/2] stubs: Provide parallel_mm_init stub version List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: mrezanin@redhat.com, qemu-devel@nongnu.org Cc: armbru@redhat.com On 12/05/2015 08:22, mrezanin@redhat.com wrote: > From: Miroslav Rezanina > > mips build fail with link error in case PARALLEL_CONFIG is disabled as > hw/mips/mips_jazz.c calls parallel_mm_init. Due to dependecies to content > of parallel.c we can't simply move it to hw/isa/isa-devices.c. > > This patch adds stubs/parallel.c file that contains stub version of > parallel_mm_init. This ensure successful build with PARALLEL_CONFIG disabled. > > Signed-off-by: Miroslav Rezanina > --- > stubs/Makefile.objs | 1 + > stubs/parallel.c | 8 ++++++++ > 2 files changed, 9 insertions(+) > create mode 100644 stubs/parallel.c > > diff --git a/stubs/Makefile.objs b/stubs/Makefile.objs > index 8beff4c..ad4e110 100644 > --- a/stubs/Makefile.objs > +++ b/stubs/Makefile.objs > @@ -24,6 +24,7 @@ stub-obj-y += mon-printf.o > stub-obj-y += mon-set-error.o > stub-obj-y += monitor-init.o > stub-obj-y += notify-event.o > +stub-obj-y += parallel.o > stub-obj-$(CONFIG_SPICE) += qemu-chr-open-spice.o > stub-obj-y += qtest.o > stub-obj-y += reset.o > diff --git a/stubs/parallel.c b/stubs/parallel.c > new file mode 100644 > index 0000000..8293d52 > --- /dev/null > +++ b/stubs/parallel.c > @@ -0,0 +1,8 @@ > +#include "hw/i386/pc.h" > + > +bool parallel_mm_init(MemoryRegion *address_space, > + hwaddr base, int it_shift, qemu_irq irq, > + CharDriverState *chr) > +{ > + return false; > +} > I think removing CONFIG_PARALLEL from a board that hardcodes its presence makes little sense, so I would just drop this patch. Paolo