From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34593) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YsEqA-0001F6-I4 for qemu-devel@nongnu.org; Tue, 12 May 2015 14:23:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YsEq9-00062h-Fi for qemu-devel@nongnu.org; Tue, 12 May 2015 14:23:38 -0400 Message-ID: <55524523.4060200@redhat.com> Date: Tue, 12 May 2015 12:23:31 -0600 From: Eric Blake MIME-Version: 1.0 References: <1431446962-9860-1-git-send-email-berrange@redhat.com> <1431446962-9860-4-git-send-email-berrange@redhat.com> In-Reply-To: <1431446962-9860-4-git-send-email-berrange@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="qC2g2R2eW1tTt6G3JckM2HuFGL4tqJWjB" Subject: Re: [Qemu-devel] [PATCH 3/5] util: allow \n to terminate password input List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , qemu-devel@nongnu.org Cc: Kevin Wolf , qemu-block@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --qC2g2R2eW1tTt6G3JckM2HuFGL4tqJWjB Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/12/2015 10:09 AM, Daniel P. Berrange wrote: > The qemu_read_password() method looks for \r to terminate the > reading of the a password. This is what will be seen when > reading the password from a TTY. When scripting though, it is > useful to be able to send the password via a pipe, in which > case we must look for \n to terminate password input. >=20 > Signed-off-by: Daniel P. Berrange > --- > util/oslib-posix.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --qC2g2R2eW1tTt6G3JckM2HuFGL4tqJWjB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVUkUjAAoJEKeha0olJ0NqmlMH/3uZIMvfPUJ52EHDN0FoSTgt HYEBss5kg6/YaNpkVmtvRxxbCMfWEaXS4NCuuQtONSUVXp/xh/wWdGGxbHH/poiA HlBKEB2U2fDT+OA+iyZ/CRblCOq1NKcAjvwWDauRl6/hhatF0kDokTzzAJBfUm81 iujkSH+vwZOl89mqa4jDpI9Cz9NFO+kGt4i1RCTN+7EUdojWnmYBPFHpta+P6m1F qUbVKBgah0vGvqiqArNBjVEa52Qj9KEOPMNQh1ONrPR5OE+oKDNUu+ef/JoARvoW W+p04YlqslL7nORs6OBveqsR2mJvUJh7TzG0/2bzKJPgD6Fv8xboPm4Vp7Ho8ck= =J85A -----END PGP SIGNATURE----- --qC2g2R2eW1tTt6G3JckM2HuFGL4tqJWjB--