From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40725) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YsF9O-0004rd-W0 for qemu-devel@nongnu.org; Tue, 12 May 2015 14:43:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YsEzm-0001DW-Dz for qemu-devel@nongnu.org; Tue, 12 May 2015 14:33:35 -0400 Message-ID: <55524755.4010301@redhat.com> Date: Tue, 12 May 2015 12:32:53 -0600 From: Eric Blake MIME-Version: 1.0 References: <1431446962-9860-1-git-send-email-berrange@redhat.com> <1431446962-9860-5-git-send-email-berrange@redhat.com> In-Reply-To: <1431446962-9860-5-git-send-email-berrange@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="lMp57CgKDerjwv5DkFlAuGnT3i1Pewahs" Subject: Re: [Qemu-devel] [PATCH 4/5] qemu-io: prompt for encryption keys when required List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , qemu-devel@nongnu.org Cc: Kevin Wolf , qemu-block@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --lMp57CgKDerjwv5DkFlAuGnT3i1Pewahs Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/12/2015 10:09 AM, Daniel P. Berrange wrote: > The qemu-io tool does not check if the image is encrypted so > historically would silently corrupt the sectors by writing > plain text data into them instead of cipher text. The earlier > commit turns this mistake into a fatal abort, so check for > encryption and prompt for key when required. Doesn't that mean that 'git bisect' gives a crashing qemu-io for 3 patches? Should this be rearranged so that 1/5 comes after this to avoid triggering the abort? >=20 > This enables us to add unit tests to ensure we don't break > the ability of qemu-img to convert existing encrypted qcow2 > files into a non-encrypted format. >=20 > Signed-off-by: Daniel P. Berrange > --- > qemu-io.c | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --lMp57CgKDerjwv5DkFlAuGnT3i1Pewahs Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVUkdVAAoJEKeha0olJ0NqPtcH/if85JzlEIIY9ToJG9fPLLnv 3peC7QTngdVrO6IftWCcj2DBEc8rnvTTmUyhxmqEpVdzrXGPXhwL/AmT1eClhQK0 YEBmF46wRXHPVBEGvc81113P0cVxYj7RBE/czGvWG6n9ps4JFluNOojj9SqkoVhx 7pbo4Qxexg35yf/5+6AEfce1fGCSuipNTPAAy6FUcvZHc9iMecXzYXwF6n94NlJR R17nJaO4dPMEGpywBp6uLZkYEEUKiKKPQh1qgyR3hr2LkLlGidi7M/75w/tMyws8 /mBeGw0UUAsiahgV4P44borBGa4bdr5tjDVI6OFfzG+3jWeZmx37u2pYxexSvUw= =Qew7 -----END PGP SIGNATURE----- --lMp57CgKDerjwv5DkFlAuGnT3i1Pewahs--