From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47635)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jsnow@redhat.com>) id 1YsFVm-0002zT-V7
	for qemu-devel@nongnu.org; Tue, 12 May 2015 15:06:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jsnow@redhat.com>) id 1YsFVm-0004cw-0k
	for qemu-devel@nongnu.org; Tue, 12 May 2015 15:06:38 -0400
Message-ID: <55524F36.2010908@redhat.com>
Date: Tue, 12 May 2015 15:06:30 -0400
From: John Snow <jsnow@redhat.com>
MIME-Version: 1.0
References: <1431446962-9860-1-git-send-email-berrange@redhat.com>	<1431446962-9860-6-git-send-email-berrange@redhat.com>
	<555247FC.4060009@redhat.com>
In-Reply-To: <555247FC.4060009@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH 5/5] tests: add test case for
 encrypted qcow2 read/write
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>, "Daniel P. Berrange" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: Fam Zheng <famz@redhat.com>, qemu-block@nongnu.org



On 05/12/2015 02:35 PM, Eric Blake wrote:
> On 05/12/2015 10:09 AM, Daniel P. Berrange wrote:
>> Add a simple test case for qemu-iotests that covers read/write 
>> with encrypted qcow2 files.
>> 
>> Signed-off-by: Daniel P. Berrange <berrange@redhat.com> --- 
>> tests/qemu-iotests/131     | 69
>> ++++++++++++++++++++++++++++++++++++++++++++++ 
>> tests/qemu-iotests/131.out | 46 +++++++++++++++++++++++++++++++ 
>> tests/qemu-iotests/group   |  1 + 3 files changed, 116
>> insertions(+) create mode 100755 tests/qemu-iotests/131 create
>> mode 100644 tests/qemu-iotests/131.out
>> 
>> diff --git a/tests/qemu-iotests/131 b/tests/qemu-iotests/131 new
>> file mode 100755 index 0000000..f44b0a0 --- /dev/null +++
>> b/tests/qemu-iotests/131 @@ -0,0 +1,69 @@ +#!/bin/bash +# +# Test
>> encrypted read/write using plain bdrv_read/bdrv_write +# +#
>> Copyright (C) 2009 Red Hat, Inc.
> 
> Copy-and-paste strikes again; welcome to 2015.  With that fixed, 
> Reviewed-by: Eric Blake <eblake@redhat.com>
> 

Fam Zheng already has a patch on-list that uses test 131, and I think
his patch was submitted first.

(Unless we want to play the "Who gets merged first?" game.)

--js