From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57989) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YsGQB-0002OM-EZ for qemu-devel@nongnu.org; Tue, 12 May 2015 16:04:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YsGQA-0005ra-GK for qemu-devel@nongnu.org; Tue, 12 May 2015 16:04:55 -0400 Message-ID: <55525CDE.7030505@redhat.com> Date: Tue, 12 May 2015 14:04:46 -0600 From: Eric Blake MIME-Version: 1.0 References: <1431105726-3682-1-git-send-email-kwolf@redhat.com> <1431105726-3682-15-git-send-email-kwolf@redhat.com> In-Reply-To: <1431105726-3682-15-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Gfkscvxm1k6ArXoA2nfXaOxXLKlQsrld6" Subject: Re: [Qemu-devel] [PATCH 14/34] qcow2: Factor out qcow2_update_options() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: mreitz@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Gfkscvxm1k6ArXoA2nfXaOxXLKlQsrld6 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/08/2015 11:21 AM, Kevin Wolf wrote: > Eventually we want to be able to change options at runtime. As a first > step towards that goal, separate some option handling code from the > general initialisation code in qcow2_open(). >=20 > Signed-off-by: Kevin Wolf > --- > block/qcow2.c | 135 +++++++++++++++++++++++++++++++++-----------------= -------- > 1 file changed, 76 insertions(+), 59 deletions(-) >=20 > + } else { > + error_setg(errp, "Unsupported value '%s' for qcow2 option " > + "'overlap-check'. Allowed are either of the followi= ng: " > + "none, constant, cached, all", opt_overlap_check); Pre-existing due to code motion, but I find s/either/any/ easier to read.= Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Gfkscvxm1k6ArXoA2nfXaOxXLKlQsrld6 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVUlzeAAoJEKeha0olJ0NqYCcH/1YsCNXkbN89iqH7BNIvs8CY xesIUNy750NB3KQKPlSr/OV0t6uHPdTToV6rYQKIgQSoA1wYWdbawMvA8AGVrKVc aCdCT9pulX3G7XLoF97w6jz7bXB1k2CDquuxKPdnH+YigtPG/nyDFTX51e4cojWW TjY0pH0fGuSt1ijb1xRtN0DHBXeDxQOx+ZE3cnLT89QrK4XDEwPnaqqY1U0EKDQ3 aIc3WkG9xzVD93zg4W25fDtczpBB4EUaDdk8c+MSz6pmkGwt11jnopxnnCu+ZEIL db/UhdQMCZW6DNPoDW4LXDbrwQ8KgrP7Au540yfSTc1A3pALUIgqGQa+sIihhD4= =AU6Y -----END PGP SIGNATURE----- --Gfkscvxm1k6ArXoA2nfXaOxXLKlQsrld6--