Re: [Qemu-devel] [PATCH] qapi: add dirty bitmap status

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1109 bytes --]

On 05/12/2015 01:53 PM, John Snow wrote:
> Bitmaps can be in a handful of different states with potentially
> more to come as we tool around with migration and persistence patches.
> 
> Instead of having a bunch of boolean fields, it was suggested that we
> just have an enum status field that will help expose the reason to
> management APIs why certain bitmaps may be unavailable for various
> commands
> 
> (e.g. busy in another operation, busy being migrated, etc.)

Might be worth mentioning that this is an API change, but safe because
the old API is unreleased (and therefore, this patch MUST go in the 2.4
time frame, if at all).

> 
> Suggested-by: Eric Blake <eblake@redhat.com>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>  block.c               | 13 ++++++++++++-
>  include/block/block.h |  1 +
>  qapi/block-core.json  | 23 +++++++++++++++++++++--
>  3 files changed, 34 insertions(+), 3 deletions(-)
> 

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]