From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58297) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YsGRk-0003Wy-Hj for qemu-devel@nongnu.org; Tue, 12 May 2015 16:06:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YsGRg-0006Sp-GW for qemu-devel@nongnu.org; Tue, 12 May 2015 16:06:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56061) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YsGRg-0006Sl-AV for qemu-devel@nongnu.org; Tue, 12 May 2015 16:06:28 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 100B5BBB2C for ; Tue, 12 May 2015 20:06:28 +0000 (UTC) Message-ID: <55525D43.6060402@redhat.com> Date: Tue, 12 May 2015 14:06:27 -0600 From: Eric Blake MIME-Version: 1.0 References: <1431460381-8530-1-git-send-email-jsnow@redhat.com> In-Reply-To: <1431460381-8530-1-git-send-email-jsnow@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="QhmoWBxSTAp3Wpex8cJa3dPnCrbDc7Orm" Subject: Re: [Qemu-devel] [PATCH] qapi: add dirty bitmap status List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --QhmoWBxSTAp3Wpex8cJa3dPnCrbDc7Orm Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/12/2015 01:53 PM, John Snow wrote: > Bitmaps can be in a handful of different states with potentially > more to come as we tool around with migration and persistence patches. >=20 > Instead of having a bunch of boolean fields, it was suggested that we > just have an enum status field that will help expose the reason to > management APIs why certain bitmaps may be unavailable for various > commands >=20 > (e.g. busy in another operation, busy being migrated, etc.) Might be worth mentioning that this is an API change, but safe because the old API is unreleased (and therefore, this patch MUST go in the 2.4 time frame, if at all). >=20 > Suggested-by: Eric Blake > Signed-off-by: John Snow > --- > block.c | 13 ++++++++++++- > include/block/block.h | 1 + > qapi/block-core.json | 23 +++++++++++++++++++++-- > 3 files changed, 34 insertions(+), 3 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --QhmoWBxSTAp3Wpex8cJa3dPnCrbDc7Orm Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVUl1DAAoJEKeha0olJ0NqAV4IAIHOOemL0zVCJFKSiIzoq5Xt AbnGo27NXoyFnGgHvZbzz0zLcgaSkkgaa92PZtTiroZZ+4x6j9s7pJTfI4yPV7F2 kxr++xXHYctG1HdonQHEWJt46HaNq6PFBztlSZ5SHlIWtZQMJY7b98pqpidWG21v KtUpw2cuxRMHXoMBs3BCKU9hJgefTa7N16p4YskVBXapfP8sCwPP/FGn7ERxwb6m MgaxzLgoP1aDw9vLSSmlybDl1ZPOJsG1oz0Nkf+Pjs88MA4HEGhXILWG/fFSa5Yo 6/EPZXwZEjlsDVv7IC0ADFlT1DJtYBffzgcoAdlVHUFqsfVtB/5oKLbUqEpnHUw= =pzOr -----END PGP SIGNATURE----- --QhmoWBxSTAp3Wpex8cJa3dPnCrbDc7Orm--