From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58644) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YsGSt-0004Xr-P1 for qemu-devel@nongnu.org; Tue, 12 May 2015 16:07:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YsGSm-0006xd-UV for qemu-devel@nongnu.org; Tue, 12 May 2015 16:07:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42163) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YsGSm-0006vw-Mx for qemu-devel@nongnu.org; Tue, 12 May 2015 16:07:36 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t4CK7aRg024233 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Tue, 12 May 2015 16:07:36 -0400 Message-ID: <55525D87.1040101@redhat.com> Date: Tue, 12 May 2015 16:07:35 -0400 From: John Snow MIME-Version: 1.0 References: <1431460381-8530-1-git-send-email-jsnow@redhat.com> <55525D43.6060402@redhat.com> In-Reply-To: <55525D43.6060402@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] qapi: add dirty bitmap status List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-devel@nongnu.org On 05/12/2015 04:06 PM, Eric Blake wrote: > On 05/12/2015 01:53 PM, John Snow wrote: >> Bitmaps can be in a handful of different states with potentially >> more to come as we tool around with migration and persistence >> patches. >> >> Instead of having a bunch of boolean fields, it was suggested >> that we just have an enum status field that will help expose the >> reason to management APIs why certain bitmaps may be unavailable >> for various commands >> >> (e.g. busy in another operation, busy being migrated, etc.) > > Might be worth mentioning that this is an API change, but safe > because the old API is unreleased (and therefore, this patch MUST > go in the 2.4 time frame, if at all). > Good thing you mentioned it! :) >> >> Suggested-by: Eric Blake Signed-off-by: John >> Snow --- block.c | 13 >> ++++++++++++- include/block/block.h | 1 + qapi/block-core.json >> | 23 +++++++++++++++++++++-- 3 files changed, 34 insertions(+), 3 >> deletions(-) >> > > Reviewed-by: Eric Blake > Thanks!