From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37915)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1YsGm7-0004pV-2o
	for qemu-devel@nongnu.org; Tue, 12 May 2015 16:27:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1YsGm2-0005mF-2a
	for qemu-devel@nongnu.org; Tue, 12 May 2015 16:27:34 -0400
Received: from mail-qc0-x22a.google.com ([2607:f8b0:400d:c01::22a]:36147)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1YsGm1-0005lM-Mp
	for qemu-devel@nongnu.org; Tue, 12 May 2015 16:27:29 -0400
Received: by qcbgy10 with SMTP id gy10so11364410qcb.3
	for <qemu-devel@nongnu.org>; Tue, 12 May 2015 13:27:29 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <5552622D.6020305@twiddle.net>
Date: Tue, 12 May 2015 13:27:25 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1431462031-46912-1-git-send-email-agraf@suse.de>
In-Reply-To: <1431462031-46912-1-git-send-email-agraf@suse.de>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2] s390x: Add laa and laag instructions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>, qemu-devel@nongnu.org

On 05/12/2015 01:20 PM, Alexander Graf wrote:
> +static void in2_m2_32s_atomic(DisasContext *s, DisasFields *f, DisasOps *o)
> +{
> +    /* XXX should reserve the address */
> +    in2_m2_32s(s, f, o);
> +}
> +#define SPEC_in2_m2_32s_atomic 0
> +
> +static void in2_m2_64_atomic(DisasContext *s, DisasFields *f, DisasOps *o)
> +{
> +    /* XXX should reserve the address */
> +    in2_m2_64(s, f, o);
> +}
> +#define SPEC_in2_m2_64_atomic 0
> +

I think these should save the address in o->addr1 so that you don't have to
recompute it in the wout functions.

Otherwise I think this is a great scheme, making it easy to implement this
whole family of instructions.


r~