Re: [Qemu-devel] [PATCH v2] s390x: Add laa and laag instructions

[Alexander Graf <agraf@suse.de>]

On 05/12/2015 10:27 PM, Richard Henderson wrote:
> On 05/12/2015 01:20 PM, Alexander Graf wrote:
>> +static void in2_m2_32s_atomic(DisasContext *s, DisasFields *f, DisasOps *o)
>> +{
>> +    /* XXX should reserve the address */
>> +    in2_m2_32s(s, f, o);
>> +}
>> +#define SPEC_in2_m2_32s_atomic 0
>> +
>> +static void in2_m2_64_atomic(DisasContext *s, DisasFields *f, DisasOps *o)
>> +{
>> +    /* XXX should reserve the address */
>> +    in2_m2_64(s, f, o);
>> +}
>> +#define SPEC_in2_m2_64_atomic 0
>> +
> I think these should save the address in o->addr1 so that you don't have to
> recompute it in the wout functions.

But wouldn't it really be "addr2"? This is the address source for the 
second argument after all.


Alex

>
> Otherwise I think this is a great scheme, making it easy to implement this
> whole family of instructions.
>
>
> r~