From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42577) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YsH0E-0000LD-LL for qemu-devel@nongnu.org; Tue, 12 May 2015 16:42:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YsH09-0002ak-Mf for qemu-devel@nongnu.org; Tue, 12 May 2015 16:42:10 -0400 Received: from cantor2.suse.de ([195.135.220.15]:37759 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YsH09-0002aO-Ft for qemu-devel@nongnu.org; Tue, 12 May 2015 16:42:05 -0400 Message-ID: <55526599.9040700@suse.de> Date: Tue, 12 May 2015 22:42:01 +0200 From: Alexander Graf MIME-Version: 1.0 References: <1431462031-46912-1-git-send-email-agraf@suse.de> <5552622D.6020305@twiddle.net> In-Reply-To: <5552622D.6020305@twiddle.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] s390x: Add laa and laag instructions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson , qemu-devel@nongnu.org On 05/12/2015 10:27 PM, Richard Henderson wrote: > On 05/12/2015 01:20 PM, Alexander Graf wrote: >> +static void in2_m2_32s_atomic(DisasContext *s, DisasFields *f, DisasOps *o) >> +{ >> + /* XXX should reserve the address */ >> + in2_m2_32s(s, f, o); >> +} >> +#define SPEC_in2_m2_32s_atomic 0 >> + >> +static void in2_m2_64_atomic(DisasContext *s, DisasFields *f, DisasOps *o) >> +{ >> + /* XXX should reserve the address */ >> + in2_m2_64(s, f, o); >> +} >> +#define SPEC_in2_m2_64_atomic 0 >> + > I think these should save the address in o->addr1 so that you don't have to > recompute it in the wout functions. But wouldn't it really be "addr2"? This is the address source for the second argument after all. Alex > > Otherwise I think this is a great scheme, making it easy to implement this > whole family of instructions. > > > r~