From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50887)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1YsHaW-0006DK-Uo
	for qemu-devel@nongnu.org; Tue, 12 May 2015 17:19:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1YsHaT-0007vu-Py
	for qemu-devel@nongnu.org; Tue, 12 May 2015 17:19:40 -0400
Received: from mail-qg0-x232.google.com ([2607:f8b0:400d:c04::232]:34682)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1YsHaT-0007vm-MI
	for qemu-devel@nongnu.org; Tue, 12 May 2015 17:19:37 -0400
Received: by qgfi89 with SMTP id i89so11655802qgf.1
	for <qemu-devel@nongnu.org>; Tue, 12 May 2015 14:19:37 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <55526E65.7050803@twiddle.net>
Date: Tue, 12 May 2015 14:19:33 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1431462031-46912-1-git-send-email-agraf@suse.de>
	<5552622D.6020305@twiddle.net> <555266A4.7050100@suse.de>
In-Reply-To: <555266A4.7050100@suse.de>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2] s390x: Add laa and laag instructions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>, qemu-devel@nongnu.org

On 05/12/2015 01:46 PM, Alexander Graf wrote:
> On 05/12/2015 10:27 PM, Richard Henderson wrote:
>> On 05/12/2015 01:20 PM, Alexander Graf wrote:
>>> +static void in2_m2_32s_atomic(DisasContext *s, DisasFields *f, DisasOps *o)
>>> +{
>>> +    /* XXX should reserve the address */
>>> +    in2_m2_32s(s, f, o);
>>> +}
>>> +#define SPEC_in2_m2_32s_atomic 0
>>> +
>>> +static void in2_m2_64_atomic(DisasContext *s, DisasFields *f, DisasOps *o)
>>> +{
>>> +    /* XXX should reserve the address */
>>> +    in2_m2_64(s, f, o);
>>> +}
>>> +#define SPEC_in2_m2_64_atomic 0
>>> +
>> I think these should save the address in o->addr1 so that you don't have to
>> recompute it in the wout functions.
> 
> But I suppose you basically mean something like this?

Yes.

There's an in1_la2 that does what your get_a2 does.
Again, slightly misnamed, but that's the beauty of these atomic ops -- same
fields have gotten renamed.


r~