From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50517) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YsLTa-0002um-Tt for qemu-devel@nongnu.org; Tue, 12 May 2015 21:28:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YsLTX-0001N4-OZ for qemu-devel@nongnu.org; Tue, 12 May 2015 21:28:46 -0400 Received: from mail-qk0-x236.google.com ([2607:f8b0:400d:c09::236]:36487) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YsLTX-0001My-JB for qemu-devel@nongnu.org; Tue, 12 May 2015 21:28:43 -0400 Received: by qku63 with SMTP id 63so18915133qku.3 for ; Tue, 12 May 2015 18:28:43 -0700 (PDT) Sender: Richard Henderson Message-ID: <5552A8C7.8050708@twiddle.net> Date: Tue, 12 May 2015 18:28:39 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1431467407-83836-1-git-send-email-agraf@suse.de> In-Reply-To: <1431467407-83836-1-git-send-email-agraf@suse.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3] s390x: Add interlocked access facility 1 instructions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf , qemu-devel@nongnu.org On 05/12/2015 02:50 PM, Alexander Graf wrote: > We're currently missing all instructions defined by the "interlocked-access > facility 1" which is part of zEC12. This patch implements all of them except > for LPD and LPDG. > > Signed-off-by: Alexander Graf > > --- > > v1 -> v2: > > - move atomic specific bits into load/store helpers, leave actual op > as normal op we can reuse > > v2 -> v3: > > - use addr1 to save a2, remove get_a2 again > - implement the other instructions as well Reviewed-by: Richard Henderson r~