From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39120) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YsSGT-0005MI-67 for qemu-devel@nongnu.org; Wed, 13 May 2015 04:43:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YsSGS-0006F2-8l for qemu-devel@nongnu.org; Wed, 13 May 2015 04:43:41 -0400 Sender: Paolo Bonzini Message-ID: <55530EAD.5070104@redhat.com> Date: Wed, 13 May 2015 10:43:25 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1431522928-5292-1-git-send-email-famz@redhat.com> In-Reply-To: <1431522928-5292-1-git-send-email-famz@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] iscsi: Remove pointless runtime check of macro value List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org On 13/05/2015 15:15, Fam Zheng wrote: > raw_bsd already has QEMU_BUILD_BUG_ON(BDRV_SECTOR_SIZE != 512), so iscsi > should relax. It's okay to have the same QEMU_BUILD_BUG_ON in different places. However, you're right that this should be a compile-time check rather than run-time check. Paolo > Signed-off-by: Fam Zheng > --- > block/iscsi.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/block/iscsi.c b/block/iscsi.c > index 8fca1d3..14e97a6 100644 > --- a/block/iscsi.c > +++ b/block/iscsi.c > @@ -1323,13 +1323,6 @@ static int iscsi_open(BlockDriverState *bs, QDict *options, int flags, > const char *filename; > int i, ret = 0; > > - if ((BDRV_SECTOR_SIZE % 512) != 0) { > - error_setg(errp, "iSCSI: Invalid BDRV_SECTOR_SIZE. " > - "BDRV_SECTOR_SIZE(%lld) is not a multiple " > - "of 512", BDRV_SECTOR_SIZE); > - return -EINVAL; > - } > - > opts = qemu_opts_create(&runtime_opts, NULL, 0, &error_abort); > qemu_opts_absorb_qdict(opts, options, &local_err); > if (local_err) { >