From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42425)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1YsVjo-0005Pa-Rj
	for qemu-devel@nongnu.org; Wed, 13 May 2015 08:26:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1YsVjo-0006HO-0B
	for qemu-devel@nongnu.org; Wed, 13 May 2015 08:26:12 -0400
Message-ID: <555342DB.4020505@redhat.com>
Date: Wed, 13 May 2015 14:26:03 +0200
From: Max Reitz <mreitz@redhat.com>
MIME-Version: 1.0
References: <1431105726-3682-1-git-send-email-kwolf@redhat.com>
	<1431105726-3682-22-git-send-email-kwolf@redhat.com>
In-Reply-To: <1431105726-3682-22-git-send-email-kwolf@redhat.com>
Content-Type: text/plain; charset=iso-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 21/34] block: Consider all block layer
	options in append_open_options
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org
Cc: armbru@redhat.com, qemu-devel@nongnu.org

On 08.05.2015 19:21, Kevin Wolf wrote:
> The code already special-cased "node-name", which is currently the only
> option passed in the QDict that isn't driver-specific. Generalise the
> code to take all general block layer options into consideration.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>   block.c | 26 ++++++++++++++++++--------
>   1 file changed, 18 insertions(+), 8 deletions(-)

Reviewed-by: Max Reitz <mreitz@redhat.com>