From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44336) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YsZwO-0002ZR-Fq for qemu-devel@nongnu.org; Wed, 13 May 2015 12:55:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YsZwK-0004UL-DL for qemu-devel@nongnu.org; Wed, 13 May 2015 12:55:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47301) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YsZwK-0004TX-5e for qemu-devel@nongnu.org; Wed, 13 May 2015 12:55:24 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t4DGtMph001530 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 13 May 2015 12:55:23 -0400 Message-ID: <555381F9.8000301@redhat.com> Date: Wed, 13 May 2015 10:55:21 -0600 From: Eric Blake MIME-Version: 1.0 References: <9f24c75fdb3b0bf78f5dc72fc50791649115410e.1431527124.git.pkrempa@redhat.com> In-Reply-To: <9f24c75fdb3b0bf78f5dc72fc50791649115410e.1431527124.git.pkrempa@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Td1o3FMFWspbqao8IxnuxdcF0kDpUgowI" Subject: Re: [Qemu-devel] [PATCH] util: socket: Add missing localaddr and localport option for DGRAM socket List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Krempa , qemu-devel@nongnu.org Cc: Markus Armbruster This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Td1o3FMFWspbqao8IxnuxdcF0kDpUgowI Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/13/2015 08:44 AM, Peter Krempa wrote: > The 'socket_optslist' structure does not contain the 'localaddr' and > 'localport' options that are parsed in case you are creating a > 'connect' type UDP character device. This causes abort of qemu after > commit: >=20 > commit f43e47dbf6de24db20ec9b588bb6cc762093dd69 > Author: Markus Armbruster > Date: Thu Feb 12 17:52:20 2015 +0100 >=20 > QemuOpts: Drop qemu_opt_set(), rename qemu_opt_set_err(), fix use >=20 > Add the two fields so that the options can again be parsed correctly. >=20 > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=3D1220252 >=20 > Signed-off-by: Peter Krempa > --- > Cc: Eric Blake > Cc: Markus Armbruster >=20 > util/qemu-sockets.c | 6 ++++++ > 1 file changed, 6 insertions(+) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Td1o3FMFWspbqao8IxnuxdcF0kDpUgowI Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVU4H5AAoJEKeha0olJ0NqImMH/R/DNB/2Mirs5aFAAn+bFbzC v1JZRIx8Zi5ljevJX2eurJ/RfARrzoWm/DB/zpk0Hc2VevJEZ2FHksBn8stZNws/ b9JKeM5tfzyj4tjtBimvZase90vxzjYxpJYMs7x3HGs3vFGCcaqqru0O1uJrVFvm zscM4ZD6qpLlcg+ciaKyYueEu7cNLvArhloihjPDgmOWYmZrK2QPzGt2h4oMPsgY mv2Mv+InARPZKEFvoxbyT42psnEB9DXTrMSrhLrcAceAc5Q3N+PR2LxG3IPhIFen jw+jPm7nnk/udEYITObwnnyofyeO3ZhszELfeXZYLmtpgNSGU89iMkkpwyKHPz0= =k7b8 -----END PGP SIGNATURE----- --Td1o3FMFWspbqao8IxnuxdcF0kDpUgowI--