From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40537) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ysq5N-00076q-3p for qemu-devel@nongnu.org; Thu, 14 May 2015 06:09:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ysq5I-0004EX-2Q for qemu-devel@nongnu.org; Thu, 14 May 2015 06:09:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40033) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ysq5H-0004DJ-SA for qemu-devel@nongnu.org; Thu, 14 May 2015 06:09:44 -0400 Message-ID: <5554745D.2080808@redhat.com> Date: Thu, 14 May 2015 12:09:33 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1431528122-50960-1-git-send-email-cornelia.huck@de.ibm.com> <1431528122-50960-2-git-send-email-cornelia.huck@de.ibm.com> <20150513165438-mutt-send-email-mst@redhat.com> <20150513170335.2d662124.cornelia.huck@de.ibm.com> <20150513180005-mutt-send-email-mst@redhat.com> <55545BAF.4040701@redhat.com> <20150514095651.GA12939@redhat.com> <55547315.9050209@redhat.com> <20150514120542-mutt-send-email-mst@redhat.com> In-Reply-To: <20150514120542-mutt-send-email-mst@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH RFC 1/1] virtio: migrate config_vector List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Cornelia Huck , borntraeger@de.ibm.com, qemu-devel@nongnu.org, jjherne@linux.vnet.ibm.com On 14/05/2015 12:07, Michael S. Tsirkin wrote: > > If you really want that, the hook should be in the virtio device class. > > Keying on the machine type is almost never the answer, at least upstream. > > Distros can always override it if they know what they're getting into. > > I beg to disagree. Check out PC_COMPAT_ macros. I'm talking specifically about migration subsections. None of them are keyed on the machine type downstream, as far as I know. > But if you are saying > migration with virtio-ccw is just too broken ATM, so we shouldn't care > about its migration compatibility upstream, then I can buy that. Yes, I'm also saying that (and Christian must agree or they would not have posted this patch). Paolo