From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52998) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YsqWc-0007St-Sb for qemu-devel@nongnu.org; Thu, 14 May 2015 06:38:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YsqWb-0001On-M6 for qemu-devel@nongnu.org; Thu, 14 May 2015 06:37:58 -0400 Sender: Paolo Bonzini Message-ID: <55547AFD.4060603@redhat.com> Date: Thu, 14 May 2015 12:37:49 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1431431315-32079-1-git-send-email-famz@redhat.com> <1431431315-32079-6-git-send-email-famz@redhat.com> In-Reply-To: <1431431315-32079-6-git-send-email-famz@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v3 5/6] qemu-iotests: Add test case for mirror with unmap List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: Stefan Hajnoczi , qemu-block@nongnu.org, wangxiaolong@ucloud.cn On 12/05/2015 13:48, Fam Zheng wrote: > This checks that the discard on mirror source that effectively zeroes > data is also reflected by the data of target. > > Signed-off-by: Fam Zheng > Reviewed-by: John Snow > --- > tests/qemu-iotests/131 | 59 ++++++++++++++++++++++++++++++++++++++++++++++ > tests/qemu-iotests/131.out | 5 ++++ > tests/qemu-iotests/group | 1 + > 3 files changed, 65 insertions(+) > create mode 100644 tests/qemu-iotests/131 > create mode 100644 tests/qemu-iotests/131.out > > diff --git a/tests/qemu-iotests/131 b/tests/qemu-iotests/131 > new file mode 100644 > index 0000000..f53ef6e > --- /dev/null > +++ b/tests/qemu-iotests/131 > @@ -0,0 +1,59 @@ > +#!/usr/bin/env python > +# > +# Test mirror with unmap > +# > +# Copyright (C) 2015 Red Hat, Inc. > +# > +# This program is free software; you can redistribute it and/or modify > +# it under the terms of the GNU General Public License as published by > +# the Free Software Foundation; either version 2 of the License, or > +# (at your option) any later version. > +# > +# This program is distributed in the hope that it will be useful, > +# but WITHOUT ANY WARRANTY; without even the implied warranty of > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +# GNU General Public License for more details. > +# > +# You should have received a copy of the GNU General Public License > +# along with this program. If not, see . > +# > + > +import time > +import os > +import iotests > +from iotests import qemu_img, qemu_io > + > +test_img = os.path.join(iotests.test_dir, 'test.img') > +target_img = os.path.join(iotests.test_dir, 'target.img') > + > +class TestSingleDrive(iotests.QMPTestCase): > + image_len = 2 * 1024 * 1024 # MB > + > + def setUp(self): > + # Write data to the image so we can compare later > + qemu_img('create', '-f', iotests.imgfmt, test_img, str(TestSingleDrive.image_len)) > + qemu_io('-f', iotests.imgfmt, '-c', 'write -P0x5d 0 2M', test_img) > + > + self.vm = iotests.VM().add_drive(test_img, 'discard=unmap') > + self.vm.launch() > + > + def tearDown(self): > + self.vm.shutdown() > + os.remove(test_img) > + try: > + os.remove(target_img) > + except OSError: > + pass > + > + def test_mirror_discard(self): > + result = self.vm.qmp('drive-mirror', device='drive0', sync='full', > + target=target_img) > + self.assert_qmp(result, 'return', {}) > + self.vm.hmp_qemu_io('drive0', 'discard 0 64k') > + self.complete_and_wait('drive0') > + self.vm.shutdown() > + self.assertTrue(iotests.compare_images(test_img, target_img), > + 'target image does not match source after mirroring') > + > +if __name__ == '__main__': > + iotests.main(supported_fmts=['raw', 'qcow2']) > diff --git a/tests/qemu-iotests/131.out b/tests/qemu-iotests/131.out > new file mode 100644 > index 0000000..ae1213e > --- /dev/null > +++ b/tests/qemu-iotests/131.out > @@ -0,0 +1,5 @@ > +. > +---------------------------------------------------------------------- > +Ran 1 tests > + > +OK > diff --git a/tests/qemu-iotests/group b/tests/qemu-iotests/group > index 6ca3466..34b16cb 100644 > --- a/tests/qemu-iotests/group > +++ b/tests/qemu-iotests/group > @@ -128,3 +128,4 @@ > 128 rw auto quick > 129 rw auto quick > 130 rw auto quick > +131 rw auto quick > Do other "quick" tests need a QEMU binary? Paolo