From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60257) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YsrzL-0004SK-EW for qemu-devel@nongnu.org; Thu, 14 May 2015 08:11:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YsrzH-0004Xw-Tt for qemu-devel@nongnu.org; Thu, 14 May 2015 08:11:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43415) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YsrzH-0004Xi-Lx for qemu-devel@nongnu.org; Thu, 14 May 2015 08:11:39 -0400 Message-ID: <555490EE.1040802@redhat.com> Date: Thu, 14 May 2015 14:11:26 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <20150513174204.GS23627@redhat.com> <5553C651.4060000@redhat.com> <20150514111825.GE3441@redhat.com> <878ucr4bb7.fsf@blackfin.pond.sub.org> In-Reply-To: <878ucr4bb7.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Do not emulate a floppy drive when -nodefaults List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , "Daniel P. Berrange" Cc: Kevin Wolf , xen-devel@lists.xensource.com, mst@redhat.com, Stefano Stabellini , qemu-devel@nongnu.org, John Snow , rth@twiddle.net On 14/05/2015 14:02, Markus Armbruster wrote: > It should certainly be off for pc-q35-2.4 and newer. Real Q35 boards > commonly don't have an FDC (depends on the Super I/O chip used). > > We may want to keep it off for pc-i440fx-2.4 and newer. I doubt > there's a real i440FX without an FDC, but our virtual i440FX is quite > unlike a real one in other ways already. That would break libvirt for people upgrading from 2.3 to 2.4. So it's more like pc-i440fx-3.0 and pc-q35-3.0. Unless for q35 we decide to break everything and retroactively nuke the controller. (I'm still not sure why we have backwards-compatible machine types for q35). Paolo > * Create the FDC only if the option is "on". > > * Optional: make -drive if=floppy,... auto-enable it > > I wouldn't bother doing the same for -global isa-fdc.driveA=... and > such.