From: Paolo Bonzini <pbonzini@redhat.com>
To: Dimitris Aragiorgis <dimara@arrikto.com>, Kevin Wolf <kwolf@redhat.com>
Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 2/5] Fix migration in case of scsi-generic
Date: Thu, 14 May 2015 15:21:11 +0200 [thread overview]
Message-ID: <5554A147.1050800@redhat.com> (raw)
In-Reply-To: <20150514110234.GA2964@arr>
On 14/05/2015 13:02, Dimitris Aragiorgis wrote:
> Also note that QEMU seems to flush the disk cache explicitly in
> case of iSCSI, using iscsi_synchronizecache10_task() from libiscsi
> inside iscsi_co_flush().
Right, QEMU does that if type is DISK only.
> Perhaps we can also extend this approach to scsi-generic e.g. by
> calling sg_ll_sync_cache_10() from libsgutils2. This is a distinct,
> orthogonal patch that could be added in the future.
Yes. But do not use libsgutils2, just do it manually in QEMU. See
for example get_stream_blocksize in hw/scsi/scsi-generic.c.
Paolo
next prev parent reply other threads:[~2015-05-14 13:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-08 17:47 [Qemu-devel] [PATCH v2 0/5] Some fixes related to scsi-generic Dimitris Aragiorgis
2015-05-08 17:47 ` [Qemu-devel] [PATCH v2 1/5] block: Use bdrv_is_sg() everywhere Dimitris Aragiorgis
2015-05-11 10:04 ` Kevin Wolf
2015-05-08 17:47 ` [Qemu-devel] [PATCH v2 2/5] Fix migration in case of scsi-generic Dimitris Aragiorgis
2015-05-11 10:12 ` Kevin Wolf
2015-05-14 11:02 ` Dimitris Aragiorgis
2015-05-14 13:21 ` Paolo Bonzini [this message]
2015-05-08 17:47 ` [Qemu-devel] [PATCH v2 3/5] raw-posix: DPRINTF instead of DEBUG_BLOCK_PRINT Dimitris Aragiorgis
2015-05-08 20:10 ` Eric Blake
2015-05-11 16:52 ` Eric Blake
2015-05-11 10:16 ` Kevin Wolf
2015-05-11 10:21 ` Paolo Bonzini
2015-05-08 17:47 ` [Qemu-devel] [PATCH v2 4/5] raw-posix: Use DPRINTF for DEBUG_FLOPPY Dimitris Aragiorgis
2015-05-11 10:19 ` Kevin Wolf
2015-05-08 17:47 ` [Qemu-devel] [PATCH v2 5/5] raw-posix: Introduce hdev_is_sg() Dimitris Aragiorgis
2015-05-10 14:04 ` [Qemu-devel] [PATCH v2 0/5] Some fixes related to scsi-generic Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5554A147.1050800@redhat.com \
--to=pbonzini@redhat.com \
--cc=dimara@arrikto.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).