From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53807) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yst4o-0002F1-2V for qemu-devel@nongnu.org; Thu, 14 May 2015 09:21:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yst4n-00010j-87 for qemu-devel@nongnu.org; Thu, 14 May 2015 09:21:26 -0400 Message-ID: <5554A147.1050800@redhat.com> Date: Thu, 14 May 2015 15:21:11 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1431107242-31947-1-git-send-email-dimara@arrikto.com> <1431107242-31947-3-git-send-email-dimara@arrikto.com> <20150511101223.GD4962@noname.redhat.com> <20150514110234.GA2964@arr> In-Reply-To: <20150514110234.GA2964@arr> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 2/5] Fix migration in case of scsi-generic List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Dimitris Aragiorgis , Kevin Wolf Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org, stefanha@redhat.com On 14/05/2015 13:02, Dimitris Aragiorgis wrote: > Also note that QEMU seems to flush the disk cache explicitly in > case of iSCSI, using iscsi_synchronizecache10_task() from libiscsi > inside iscsi_co_flush(). Right, QEMU does that if type is DISK only. > Perhaps we can also extend this approach to scsi-generic e.g. by > calling sg_ll_sync_cache_10() from libsgutils2. This is a distinct, > orthogonal patch that could be added in the future. Yes. But do not use libsgutils2, just do it manually in QEMU. See for example get_stream_blocksize in hw/scsi/scsi-generic.c. Paolo