Re: [Qemu-devel] [PATCH 6/9] qapi: Turn generators' mandatory option -i into an argument

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1122 bytes --]

On 05/11/2015 01:24 AM, Markus Armbruster wrote:
> Mandatory option is silly, and the error handling is missing: the
> programs crash when -i isn't supplied.  Make it an argument, and check
> it properly.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  Makefile               | 14 +++++++-------
>  docs/qapi-code-gen.txt | 10 +++++-----
>  scripts/qapi.py        | 12 +++++-------
>  tests/Makefile         |  8 ++++----
>  4 files changed, 21 insertions(+), 23 deletions(-)
> 

> @@ -999,8 +996,9 @@ def parse_command_line(extra_options = "", extra_long_options = []):
>          do_c = True
>          do_h = True
>  
> -    if len(args) != 0:
> -        print >>sys.stderr, "%s: too many arguments"% sys.argv[0]
> +    if len(args) != 1:
> +        print >>sys.stderr, "%s: need exactly one argument" % sys.argv[0]

Hmm, might be affected by resolution of my review comments on 5/9; but
shouldn't affect the review.

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]