Re: [Qemu-devel] [PATCH 05/15] tap: net_tap_fd_init() can't fail, drop dead error handling

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 816 bytes --]

On 05/12/2015 06:02 AM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  net/tap.c | 14 +-------------
>  1 file changed, 1 insertion(+), 13 deletions(-)
> 

> @@ -552,14 +551,8 @@ int net_init_bridge(const NetClientOptions *opts, const char *name,
>      }
>  
>      fcntl(fd, F_SETFL, O_NONBLOCK);

Well, fcntl() could fail.  And don't we have the helper function
util/oslib-posix.c:qemu_set_nonblock() for doing this correctly?  (Then
again, that helper also ignores failures).

But the raw use of fcntl here is pre-existing and you didn't touch it,
so it doesn't affect my review of this patch.

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]