From: Richard Henderson <rth@twiddle.net>
To: Alistair Francis <alistair.francis@xilinx.com>,
edgar.iglesias@xilinx.com, qemu-devel@nongnu.org
Cc: peter.crosthwaite@xilinx.com
Subject: Re: [Qemu-devel] [RFC v1 2/3] target-microblaze: Allow the stack protection to be disabled
Date: Thu, 14 May 2015 11:36:13 -0700 [thread overview]
Message-ID: <5554EB1D.9000806@twiddle.net> (raw)
In-Reply-To: <b4018252e8e406d77d818146b47dd84c7af77220.1431583229.git.alistair.francis@xilinx.com>
On 05/13/2015 11:08 PM, Alistair Francis wrote:
> void helper_stackprot(CPUMBState *env, uint32_t addr)
> {
> - if (addr < env->slr || addr > env->shr) {
> + MicroBlazeCPU *cpu = mb_env_get_cpu(env);
> +
> + if (cpu->cfg.stackproc && (addr < env->slr || addr > env->shr)) {
This check should be done in translate.c to avoid calling this function in the
first place.
r~
next prev parent reply other threads:[~2015-05-14 18:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-14 6:08 [Qemu-devel] [RFC v1 0/3] Add Microblaze configuration options Alistair Francis
2015-05-14 6:08 ` [Qemu-devel] [RFC v1 1/3] target-microblaze: Fix up indentation Alistair Francis
2015-05-14 6:08 ` [Qemu-devel] [RFC v1 2/3] target-microblaze: Allow the stack protection to be disabled Alistair Francis
2015-05-14 18:36 ` Richard Henderson [this message]
2015-05-14 22:53 ` Alistair Francis
2015-05-15 5:26 ` Peter Crosthwaite
2015-05-15 6:51 ` Alistair Francis
2015-05-14 6:08 ` [Qemu-devel] [RFC v1 3/3] target-microblaze: Convert use-fpu to a CPU property Alistair Francis
2015-05-15 5:22 ` Peter Crosthwaite
2015-05-15 5:48 ` Alistair Francis
2015-05-15 5:52 ` Peter Crosthwaite
2015-05-15 5:56 ` Alistair Francis
2015-05-15 6:32 ` Peter Crosthwaite
2015-05-15 6:36 ` Alistair Francis
2015-05-15 6:41 ` Peter Crosthwaite
2015-05-15 11:15 ` Andreas Färber
2015-05-17 12:26 ` Alistair Francis
2015-05-17 15:12 ` Andreas Färber
2015-05-18 1:10 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5554EB1D.9000806@twiddle.net \
--to=rth@twiddle.net \
--cc=alistair.francis@xilinx.com \
--cc=edgar.iglesias@xilinx.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).