qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Stefan Weil <sw@weilnetz.de>, QEMU Trivial <qemu-trivial@nongnu.org>
Cc: QEMU Developer <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] pci: Fix compiler warning (MinGW-w64 gcc 4.9)
Date: Thu, 14 May 2015 15:22:49 -0600	[thread overview]
Message-ID: <55551229.2050702@redhat.com> (raw)
In-Reply-To: <555510C2.7020507@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 713 bytes --]

On 05/14/2015 03:16 PM, Eric Blake wrote:
>> Meanwhile, you may want to file a bug to the mingw maintainers that
>> their header is puny when compared to glibc assert() or to glib's
>> g_assert, when it comes to giving gcc decent hints.
> 
> Oh, I was right!

> 
> so it is indeed a bug in the mingw headers that __MINGW_ATTRIB_NORETURN
> was not attached to _assert's declaration.

Filed a Fedora bug at
https://bugzilla.redhat.com/show_bug.cgi?id=1221811 but of course it
will take a while for fixed headers to propagate to all distros, so this
patch is fine for qemu in the meantime.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

  reply	other threads:[~2015-05-14 21:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-14 20:38 [Qemu-devel] [PATCH] pci: Fix compiler warning (MinGW-w64 gcc 4.9) Stefan Weil
2015-05-14 21:06 ` Eric Blake
2015-05-14 21:16   ` Eric Blake
2015-05-14 21:22     ` Eric Blake [this message]
2015-05-14 21:30     ` Eric Blake
2015-05-15  8:00 ` Markus Armbruster
2015-05-15 16:20   ` Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55551229.2050702@redhat.com \
    --to=eblake@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).