From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41625) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yt13a-0006lZ-01 for qemu-devel@nongnu.org; Thu, 14 May 2015 17:52:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yt13V-0001tk-VZ for qemu-devel@nongnu.org; Thu, 14 May 2015 17:52:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55645) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yt13V-0001tg-Mh for qemu-devel@nongnu.org; Thu, 14 May 2015 17:52:37 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t4ELqaEZ021393 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Thu, 14 May 2015 17:52:36 -0400 Message-ID: <55551923.60806@redhat.com> Date: Thu, 14 May 2015 15:52:35 -0600 From: Eric Blake MIME-Version: 1.0 References: <1431432187-10993-1-git-send-email-armbru@redhat.com> <1431432187-10993-12-git-send-email-armbru@redhat.com> In-Reply-To: <1431432187-10993-12-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="HfIsUx3BXTrdrsftQbFK9eX7QDr2Ob9t7" Subject: Re: [Qemu-devel] [PATCH 11/15] tap-linux: Convert tap_open() to Error List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --HfIsUx3BXTrdrsftQbFK9eX7QDr2Ob9t7 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/12/2015 06:03 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > net/tap-linux.c | 17 +++++++++-------- > 1 file changed, 9 insertions(+), 8 deletions(-) >=20 > @@ -47,7 +46,7 @@ int tap_open(char *ifname, int ifname_size, int *vnet= _hdr, > =20 > TFR(fd =3D open(PATH_NET_TUN, O_RDWR)); > if (fd < 0) { > - error_report("could not open %s: %m", PATH_NET_TUN); > + error_setg_errno(errp, errno, "could not open %s", PATH_NET_TU= N); Oh nice - gets rid of non-portable uses of %m (of course, the file is only compiled on Linux where %m is supported, so it is not a bug fix). Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --HfIsUx3BXTrdrsftQbFK9eX7QDr2Ob9t7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVVRkjAAoJEKeha0olJ0NqSCsH/iDFjevHSKWYodr0URHZy5mg ou79Lryu7TRUkjM7yDgDUX0YQypmAgx8i5BNs/Mbp/syhn+XKq4mdWF40m1A6hoM NQsqChuu1yG1MJb3vMBykVrOI9P46GfBdSWd/GNv7tbPUewQCs9hgNNuxe8CkhF0 EmjkV7x6p1t3FcBL3sr3xyu+lGPdM4dBBj849x/OuAVrQ0aASnwTf3xJDxhF4ndb ic5Guj2/5QuhQiEyK0l+0SaoDheGyhjlodA1k43VX7j2sIm1Aqfd1VcX5VHuhsYC qOuq5FnCjkyG9hvS6n3lKPYnIuJ/X3qcjZ9AdsQt193VEqsSlxpmdNSqX9xRGMY= =1XlD -----END PGP SIGNATURE----- --HfIsUx3BXTrdrsftQbFK9eX7QDr2Ob9t7--