From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37167)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1YtFtd-0006UI-2q
	for qemu-devel@nongnu.org; Fri, 15 May 2015 09:43:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1YtFtc-0004Ld-5r
	for qemu-devel@nongnu.org; Fri, 15 May 2015 09:43:25 -0400
Received: from mail-qk0-x22a.google.com ([2607:f8b0:400d:c09::22a]:36374)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1YtFtc-0004LY-2P
	for qemu-devel@nongnu.org; Fri, 15 May 2015 09:43:24 -0400
Received: by qkgw4 with SMTP id w4so29964809qkg.3
	for <qemu-devel@nongnu.org>; Fri, 15 May 2015 06:43:23 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <5555F7F7.3020401@twiddle.net>
Date: Fri, 15 May 2015 06:43:19 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1431531457-17127-1-git-send-email-yongbok.kim@imgtec.com>	<1431531457-17127-3-git-send-email-yongbok.kim@imgtec.com>	<5553A5C4.6030902@twiddle.net>
	<55546FF2.1030405@imgtec.com> <5554BED5.3070802@twiddle.net>
	<5554F38E.3070503@twiddle.net> <5555E1DE.1010506@imgtec.com>
In-Reply-To: <5555E1DE.1010506@imgtec.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 2/2] target-mips: Misaligned memory
 accesses for MSA
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Leon Alrae <leon.alrae@imgtec.com>, Yongbok Kim <yongbok.kim@imgtec.com>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>, afaerber@suse.de, Paolo Bonzini <pbonzini@redhat.com>

On 05/15/2015 05:09 AM, Leon Alrae wrote:
> On 14/05/2015 20:12, Richard Henderson wrote:
>>   /* We know both pages are present and writable.  */
>>   if (eaddr == baddr + 15) {
>>       /* Consecutive pages in RAM.  */
>>       memcpy(baddr, register, 16);
>>   } else {
>>       /* Someone's doing an MSA store to device memory.  */
>>       for (i = 0; i < 2; ++i) {
>>           helper_ret_stq_mmu(env, vaddr + i*8, register.d[0],
>>                              make_memop_idx(MO_UNALN | MO_TEQ, mmu_idx),
>>                              GETRA());
>>       }
>>   }
> 
> We would additionally need to take care of vector elements' endianness
> before using this code. Therefore always using helper_ret_st[bwlq]_mmu
> (depending on data format) in a loop probably is simpler.

I suppose.  I'd thought one of the patches defined functions to do the
swapping, so I assumed that would still be used.


r~