From: "Andreas Färber" <afaerber@suse.de>
To: Peter Crosthwaite <crosthwaitepeter@gmail.com>, qemu-devel@nongnu.org
Cc: Alexander Graf <AGraf@suse.com>,
Peter Crosthwaite <crosthwaite.peter@gmail.com>
Subject: Re: [Qemu-devel] [PATCH] device-tree: Make a common-obj
Date: Sun, 17 May 2015 13:22:28 +0200 [thread overview]
Message-ID: <555879F4.4010103@suse.de> (raw)
In-Reply-To: <1431839773-3543-1-git-send-email-crosthwaite.peter@gmail.com>
Am 17.05.2015 um 07:16 schrieb Peter Crosthwaite:
> There is no reason for device tree API to be built per-target.
> common-obj it. There is an extraneous inclusion of config.h that
> needs to be removed.
>
> Signed-off-by: Peter Crosthwaite <crosthwaite.peter@gmail.com>
> ---
> Makefile.objs | 2 ++
> Makefile.target | 1 -
> device_tree.c | 1 -
> 3 files changed, 2 insertions(+), 2 deletions(-)
Looks okay,
Reviewed-by: Andreas Färber <afaerber@suse.de>
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Dilip Upmanyu, Graham Norton; HRB
21284 (AG Nürnberg)
prev parent reply other threads:[~2015-05-17 11:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-17 5:16 [Qemu-devel] [PATCH] device-tree: Make a common-obj Peter Crosthwaite
2015-05-17 11:22 ` Andreas Färber [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=555879F4.4010103@suse.de \
--to=afaerber@suse.de \
--cc=AGraf@suse.com \
--cc=crosthwaite.peter@gmail.com \
--cc=crosthwaitepeter@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).