From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38242)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den-lists@parallels.com>) id 1YuITZ-0007S5-9i
	for qemu-devel@nongnu.org; Mon, 18 May 2015 06:40:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <den-lists@parallels.com>) id 1YuITV-0004TC-TV
	for qemu-devel@nongnu.org; Mon, 18 May 2015 06:40:49 -0400
Received: from relay.parallels.com ([195.214.232.42]:45028)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den-lists@parallels.com>) id 1YuIRb-0003v3-8m
	for qemu-devel@nongnu.org; Mon, 18 May 2015 06:40:45 -0400
Message-ID: <5559C128.7020109@parallels.com>
Date: Mon, 18 May 2015 13:38:32 +0300
From: "Denis V. Lunev" <den-lists@parallels.com>
MIME-Version: 1.0
References: <1431620920-19710-1-git-send-email-quintela@redhat.com>
	<1431620920-19710-4-git-send-email-quintela@redhat.com>
In-Reply-To: <1431620920-19710-4-git-send-email-quintela@redhat.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 3/9] runstate: Add runstate store
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>, qemu-devel@nongnu.org

On 14/05/15 19:28, Juan Quintela wrote:
> This allows us to store the current state to send it through migration.
>
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
>   include/sysemu/sysemu.h |  1 +
>   vl.c                    | 11 +++++++++++
>   2 files changed, 12 insertions(+)
>
> diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h
> index 8a52934..c1a403e 100644
> --- a/include/sysemu/sysemu.h
> +++ b/include/sysemu/sysemu.h
> @@ -28,6 +28,7 @@ bool runstate_check(RunState state);
>   void runstate_set(RunState new_state);
>   int runstate_is_running(void);
>   bool runstate_needs_reset(void);
> +int runstate_store(char *str, int size);
>   typedef struct vm_change_state_entry VMChangeStateEntry;
>   typedef void VMChangeStateHandler(void *opaque, int running, RunState state);
>
> diff --git a/vl.c b/vl.c
> index 15bccc4..7dca13f 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -609,6 +609,17 @@ bool runstate_check(RunState state)
>       return current_run_state == state;
>   }
>
> +int runstate_store(char *str, int size)
> +{
> +    const char *state = RunState_lookup[current_run_state];
> +
> +    if (strlen(state)+1 > size) {
> +        return -1;
> +    }
> +    strncpy(str, state, strlen(state)+1);
> +    return 0;
> +}
> +
>   static void runstate_init(void)
>   {
>       const RunStateTransition *p;
>

minor. why to call strlen() twice?

if you have the length in hand it would be better to call
memcpy to copy data.