From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49438) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YuKbT-00053J-Gd for qemu-devel@nongnu.org; Mon, 18 May 2015 08:57:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YuKbS-00054v-Js for qemu-devel@nongnu.org; Mon, 18 May 2015 08:57:07 -0400 Message-ID: <5559E19A.7080604@redhat.com> Date: Mon, 18 May 2015 06:56:58 -0600 From: Eric Blake MIME-Version: 1.0 References: <20150517160052.6B12849ED81@webmail.sinamail.sina.com.cn> <5559E118.9070606@redhat.com> In-Reply-To: <5559E118.9070606@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="eJmKQPKi8ig05GqDLE80GLjHQ0ojcnxT6" Subject: Re: [Qemu-devel] [PATCH] keyboard: handle ps2 typing buffer overrun List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: penghao122@sina.com, qemu-devel Cc: qemu-stable This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --eJmKQPKi8ig05GqDLE80GLjHQ0ojcnxT6 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/18/2015 06:54 AM, Eric Blake wrote: > On 05/17/2015 10:00 AM, penghao122@sina.com wrote: >> Subject: [PATCH] keyboard: handle ps2 typing buffer overrun >=20 > This line is redundant. >=20 > Also, you have tried to send this patch more than once. Please be sure= > to include a proper 'v3' or 'v4' in the subject line, as appropriate. >=20 >> Starting a linux guest with ps2 keyboard, if you type many times durin= g leaving >> grub and into linux kernel,then you can't use keyboard after linux ini= tialization finished. >> Specally when you setup linux guest from iso file,you will type in gru= b. >=20 > s/Specally/Specifically,/ > s/file,you/file, you/ In fact, I called these out on your v2 submission. https://lists.gnu.org/archive/html/qemu-devel/2015-05/msg00938.html Sending a v3 without addressing points made in v2 is not good - it wastes everyone's time, and makes it more likely that your patch will be intentionally overlooked. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --eJmKQPKi8ig05GqDLE80GLjHQ0ojcnxT6 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVWeGaAAoJEKeha0olJ0NqEtwH/iT/AuMJFTw9c9vj/AKe7pSI weLV788SgugPkzb/xuPg3fCca8GB3DM5k0rRxaOeuCUrupo/8v2e6zzJbS+yxVd4 C5cFyWTLg78/0zGQNSi3w9xcpfXWEZwFAPtVw/6Hweef7iTtIuv7HKPqa7KIKDIH rOam91+Gz9o7UDQxGn1/4u5bPMlvBkIWY6gKIO3qNac4neQJW89wMxbEGcE/Idu/ XzPH4ezp+nKjOh75TqdJY/um/cwovp1p7N99UgW/uh+G6jaGDVEKsHTsq4ZNj26C mqEbvgMw0xenQJxs+vIsugRwwJr0wOeIUTlhEOZMB/Y3+V+eGUc4RWToSUkKPyA= =qWKU -----END PGP SIGNATURE----- --eJmKQPKi8ig05GqDLE80GLjHQ0ojcnxT6--