From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36545) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YuNBH-0003YN-52 for qemu-devel@nongnu.org; Mon, 18 May 2015 11:42:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YuNBC-00043Q-V0 for qemu-devel@nongnu.org; Mon, 18 May 2015 11:42:15 -0400 Received: from mail-qc0-x244.google.com ([2607:f8b0:400d:c01::244]:33024) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YuNBC-00041o-PL for qemu-devel@nongnu.org; Mon, 18 May 2015 11:42:10 -0400 Received: by qcvs11 with SMTP id s11so230896qcv.0 for ; Mon, 18 May 2015 08:42:10 -0700 (PDT) Sender: Richard Henderson Message-ID: <555A084D.8030501@twiddle.net> Date: Mon, 18 May 2015 08:42:05 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1431956400-19091-1-git-send-email-aurelien@aurel32.net> In-Reply-To: <1431956400-19091-1-git-send-email-aurelien@aurel32.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/3] target-s390x: fix CC computation for LOAD POSITIVE instructions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aurelien Jarno , qemu-devel@nongnu.org Cc: Alexander Graf On 05/18/2015 06:39 AM, Aurelien Jarno wrote: > LOAD POSITIVE instructions (LPR, LPGR and LPGFR) set the following > condition code: > 0: Result zero; no overflow > 1: -- > 2: Result greater than zero; no overflow > 3: Overflow > > The current code wrongly returns 1 instead of 2 in case of a result > greater than 0. This patches fixes that. This fixes the marshalling of > the value '0L' in Python. > > Cc: Richard Henderson > Cc: Alexander Graf > Signed-off-by: Aurelien Jarno > --- > target-s390x/cc_helper.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Richard Henderson r~