From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36564) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YuNBL-0003aY-ID for qemu-devel@nongnu.org; Mon, 18 May 2015 11:42:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YuNBK-0004MF-Lb for qemu-devel@nongnu.org; Mon, 18 May 2015 11:42:19 -0400 Received: from mail-qk0-x22d.google.com ([2607:f8b0:400d:c09::22d]:33370) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YuNBK-0004LB-BX for qemu-devel@nongnu.org; Mon, 18 May 2015 11:42:18 -0400 Received: by qkgv12 with SMTP id v12so37342493qkg.0 for ; Mon, 18 May 2015 08:42:17 -0700 (PDT) Sender: Richard Henderson Message-ID: <555A0855.4080002@twiddle.net> Date: Mon, 18 May 2015 08:42:13 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1431956400-19091-1-git-send-email-aurelien@aurel32.net> <1431956400-19091-2-git-send-email-aurelien@aurel32.net> In-Reply-To: <1431956400-19091-2-git-send-email-aurelien@aurel32.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/3] target-s390x: optimize (negative-) abs computation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aurelien Jarno , qemu-devel@nongnu.org Cc: Alexander Graf On 05/18/2015 06:39 AM, Aurelien Jarno wrote: > Now that movcond exists, it's easy to write (negative-) absolute value > using TCG code instead of an helper. > > Cc: Richard Henderson > Cc: Alexander Graf > Signed-off-by: Aurelien Jarno > --- > target-s390x/helper.h | 2 -- > target-s390x/int_helper.c | 22 ---------------------- > target-s390x/translate.c | 16 ++++++++++++++-- > 3 files changed, 14 insertions(+), 26 deletions(-) Reviewed-by: Richard Henderson r~