From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47233)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1YuNfH-0004Ag-1G
	for qemu-devel@nongnu.org; Mon, 18 May 2015 12:13:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1YuNfB-0004Uu-VR
	for qemu-devel@nongnu.org; Mon, 18 May 2015 12:13:14 -0400
Received: from mail-qc0-x234.google.com ([2607:f8b0:400d:c01::234]:34080)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1YuNfB-0004Ui-HF
	for qemu-devel@nongnu.org; Mon, 18 May 2015 12:13:09 -0400
Received: by qctt3 with SMTP id t3so10603766qct.1
	for <qemu-devel@nongnu.org>; Mon, 18 May 2015 09:13:09 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <555A0F90.1060603@twiddle.net>
Date: Mon, 18 May 2015 09:13:04 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <cover.1431891113.git.crosthwaite.peter@gmail.com>
	<1eddf7c8960c0082d7db599ff3486224a3e6635d.1431891113.git.crosthwaite.peter@gmail.com>
In-Reply-To: <1eddf7c8960c0082d7db599ff3486224a3e6635d.1431891113.git.crosthwaite.peter@gmail.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/2] monitor: Split mon_get_cpu fn to
	remove ENV_GET_CPU
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Crosthwaite <crosthwaitepeter@gmail.com>, qemu-devel@nongnu.org, armbru@redhat.com, lcapitulino@redhat.com, afaerber@suse.de
Cc: Peter Crosthwaite <crosthwaite.peter@gmail.com>

On 05/17/2015 12:51 PM, Peter Crosthwaite wrote:
> @@ -1208,7 +1203,6 @@ static void monitor_printc(Monitor *mon, int c)
>  static void memory_dump(Monitor *mon, int count, int format, int wsize,
>                          hwaddr addr, int is_physical)
>  {
> -    CPUArchState *env;
>      int l, line_size, i, max_digits, len;
>      uint8_t buf[16];
>      uint64_t v;
> @@ -1216,8 +1210,8 @@ static void memory_dump(Monitor *mon, int count, int format, int wsize,
>      if (format == 'i') {
>          int flags;
>          flags = 0;
> -        env = mon_get_cpu();
>  #ifdef TARGET_I386
> +        CPUArchState *env = mon_get_env();
>          if (wsize == 2) {

C99 declaration after statement.  I forget if we care or not?
Anyway, fixable by changing the line above to

    int flags = 0;

Otherwise,

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~