From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47763) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YuNhF-0007Eo-GF for qemu-devel@nongnu.org; Mon, 18 May 2015 12:15:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YuNh8-0005JV-0A for qemu-devel@nongnu.org; Mon, 18 May 2015 12:15:17 -0400 Received: from mail-qk0-x243.google.com ([2607:f8b0:400d:c09::243]:34377) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YuNh7-0005JJ-SF for qemu-devel@nongnu.org; Mon, 18 May 2015 12:15:09 -0400 Received: by qkcd200 with SMTP id d200so468793qkc.1 for ; Mon, 18 May 2015 09:15:09 -0700 (PDT) Sender: Richard Henderson Message-ID: <555A1007.4030505@twiddle.net> Date: Mon, 18 May 2015 09:15:03 -0700 From: Richard Henderson MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/2] disas: Remove uses of CPU env List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite , qemu-devel@nongnu.org, armbru@redhat.com, lcapitulino@redhat.com, afaerber@suse.de Cc: Peter Maydell , Eduardo Habkost , Peter Crosthwaite , Bastian Koppelmann , Mark Cave-Ayland , Alexander Graf , Max Filippov , Michael Walle , "Edgar E. Iglesias" , Paolo Bonzini , Guan Xuetao , Leon Alrae , Aurelien Jarno , Jia Liu On 05/17/2015 12:51 PM, Peter Crosthwaite wrote: > disas does not need to access the CPU env for any reason. Change the > APIs to accept CPU pointers instead. Small change pattern needs to be > applied to all target translate.c. This brings us closer to making > disas.o a common-obj and less architecture specific in general. > > Cc: Richard Henderson > Cc: Peter Maydell > Cc: "Edgar E. Iglesias" > Cc: Paolo Bonzini > Cc: Eduardo Habkost > Cc: Michael Walle > Cc: Aurelien Jarno > Cc: Leon Alrae > Cc: Jia Liu > Cc: Alexander Graf > Cc: Mark Cave-Ayland > Cc: Bastian Koppelmann > Cc: Guan Xuetao > Cc: Max Filippov > Signed-off-by: Peter Crosthwaite > --- > disas.c | 14 +++++++------- > include/disas/disas.h | 4 ++-- > include/qemu/log.h | 4 ++-- > monitor.c | 2 +- > target-alpha/translate.c | 2 +- > target-arm/translate-a64.c | 2 +- > target-arm/translate.c | 2 +- > target-cris/translate.c | 2 +- > target-i386/translate.c | 2 +- > target-lm32/translate.c | 2 +- > target-m68k/translate.c | 2 +- > target-microblaze/translate.c | 2 +- > target-mips/translate.c | 2 +- > target-openrisc/translate.c | 2 +- > target-ppc/translate.c | 2 +- > target-s390x/translate.c | 2 +- > target-sh4/translate.c | 2 +- > target-sparc/translate.c | 2 +- > target-tricore/translate.c | 2 +- > target-unicore32/translate.c | 2 +- > target-xtensa/translate.c | 2 +- > 21 files changed, 29 insertions(+), 29 deletions(-) Reviewed-by: Richard Henderson r~