From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43517) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YuP0P-0004QR-5l for qemu-devel@nongnu.org; Mon, 18 May 2015 13:39:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YuP0O-00050W-AK for qemu-devel@nongnu.org; Mon, 18 May 2015 13:39:09 -0400 Message-ID: <555A239F.304@redhat.com> Date: Mon, 18 May 2015 19:38:39 +0200 From: Max Reitz MIME-Version: 1.0 References: <1431669868-26804-1-git-send-email-famz@redhat.com> <1431669868-26804-5-git-send-email-famz@redhat.com> In-Reply-To: <1431669868-26804-5-git-send-email-famz@redhat.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 04/12] virtio-blk: Move complete_request to 'ops' structure List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: Kevin Wolf , qemu-block@nongnu.org, jcody@redhat.com, armbru@redhat.com, Stefan Hajnoczi , pbonzini@redhat.com On 15.05.2015 08:04, Fam Zheng wrote: > Should more ops be added to differentiate code between dataplane and > non-dataplane, the new saved_ops approach will be cleaner than messing > with N pointers. > > Signed-off-by: Fam Zheng > --- > hw/block/dataplane/virtio-blk.c | 13 ++++++++----- > hw/block/virtio-blk.c | 8 ++++++-- > include/hw/virtio/virtio-blk.h | 9 +++++++-- > 3 files changed, 21 insertions(+), 9 deletions(-) Reviewed-by: Max Reitz