[Qemu-devel] openbios.git mirror on git.qemu.org

[Qemu-devel] openbios.git mirror on git.qemu.org

[Mark Cave-Ayland]

Hi all,

I noticed last week that the openbios.git mirror on git.qemu.org hadn't
been updated after a commit I made to SVN trunk, and after some
investigation work by Stefan it seems that the upstream remote is given
as a git:// URL pointing directly to a repository at a 64.62.x.x IP address.

This is different from the official upstream SVN repository of
svn://openbios.org/openbios/ which means we're pointing at an additional
mirror somewhere.

Can anyone recall how/when the openbios.git mirror was setup on
git.qemu.org, whether it is still maintained, and if it would be
preferable to switch to the official upstream?


ATB,

Mark.

Re: [Qemu-devel] openbios.git mirror on git.qemu.org

[Stefan Hajnoczi]

[-- Attachment #1: Type: text/plain, Size: 842 bytes --]

On Fri, May 08, 2015 at 12:32:59PM +0100, Mark Cave-Ayland wrote:
> I noticed last week that the openbios.git mirror on git.qemu.org hadn't
> been updated after a commit I made to SVN trunk, and after some
> investigation work by Stefan it seems that the upstream remote is given
> as a git:// URL pointing directly to a repository at a 64.62.x.x IP address.
> 
> This is different from the official upstream SVN repository of
> svn://openbios.org/openbios/ which means we're pointing at an additional
> mirror somewhere.
> 
> Can anyone recall how/when the openbios.git mirror was setup on
> git.qemu.org, whether it is still maintained, and if it would be
> preferable to switch to the official upstream?

Ping.  Should we stick with an old mirror of OpenBIOS for QEMU 2.4 or
switch to the official upstream repo?

Stefan

[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]

Re: [Qemu-devel] openbios.git mirror on git.qemu.org

[Andreas Färber]

[-- Attachment #1: Type: text/plain, Size: 1444 bytes --]

Am 19.05.2015 um 12:42 schrieb Stefan Hajnoczi:
> On Fri, May 08, 2015 at 12:32:59PM +0100, Mark Cave-Ayland wrote:
>> I noticed last week that the openbios.git mirror on git.qemu.org hadn't
>> been updated after a commit I made to SVN trunk, and after some
>> investigation work by Stefan it seems that the upstream remote is given
>> as a git:// URL pointing directly to a repository at a 64.62.x.x IP address.
>>
>> This is different from the official upstream SVN repository of
>> svn://openbios.org/openbios/ which means we're pointing at an additional
>> mirror somewhere.
>>
>> Can anyone recall how/when the openbios.git mirror was setup on
>> git.qemu.org, whether it is still maintained, and if it would be
>> preferable to switch to the official upstream?
> 
> Ping.  Should we stick with an old mirror of OpenBIOS for QEMU 2.4 or
> switch to the official upstream repo?

I don't quite understand the question. OpenBIOS is still using SVN
AFAIK. QEMU is using Git, so I thought we always need a Git mirror for
submodules? Has the git-svn integration been extended to svn submodules
and which versions of git support that?

Unless I'm missing something, the only question is which mirror do we
use, not whether we use a mirror.

Regards,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Dilip Upmanyu, Graham Norton; HRB
21284 (AG Nürnberg)


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [Qemu-devel] openbios.git mirror on git.qemu.org

[Mark Cave-Ayland]

On 19/05/15 13:55, Andreas Färber wrote:

> Am 19.05.2015 um 12:42 schrieb Stefan Hajnoczi:
>> On Fri, May 08, 2015 at 12:32:59PM +0100, Mark Cave-Ayland wrote:
>>> I noticed last week that the openbios.git mirror on git.qemu.org hadn't
>>> been updated after a commit I made to SVN trunk, and after some
>>> investigation work by Stefan it seems that the upstream remote is given
>>> as a git:// URL pointing directly to a repository at a 64.62.x.x IP address.
>>>
>>> This is different from the official upstream SVN repository of
>>> svn://openbios.org/openbios/ which means we're pointing at an additional
>>> mirror somewhere.
>>>
>>> Can anyone recall how/when the openbios.git mirror was setup on
>>> git.qemu.org, whether it is still maintained, and if it would be
>>> preferable to switch to the official upstream?
>>
>> Ping.  Should we stick with an old mirror of OpenBIOS for QEMU 2.4 or
>> switch to the official upstream repo?
> 
> I don't quite understand the question. OpenBIOS is still using SVN
> AFAIK. QEMU is using Git, so I thought we always need a Git mirror for
> submodules? Has the git-svn integration been extended to svn submodules
> and which versions of git support that?

I'm not sure why submodules make anything different, but for an SVN
repository I can't see why the nightly cron job on git.qemu.org can't
just run "git svn fetch && git svn rebase" directly against OpenBIOS SVN
to update its master branch?

> Unless I'm missing something, the only question is which mirror do we
> use, not whether we use a mirror.

The problem at the moment is that the repository on git.qemu.org is
pointing to a git repository on a plain IP address (with no sensible
reverse DNS) and so far no-one has admitted ownership. This was a
problem last week when the repository stopped syncing with OpenBIOS SVN
trunk and both Stefan and myself had no idea who to contact in order to
get it fixed.


ATB,

Mark.

Re: [Qemu-devel] openbios.git mirror on git.qemu.org

[Peter Maydell]

On 19 May 2015 at 21:47, Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk> wrote:
> On 19/05/15 13:55, Andreas Färber wrote:
>
>> Am 19.05.2015 um 12:42 schrieb Stefan Hajnoczi:
>>> Ping.  Should we stick with an old mirror of OpenBIOS for QEMU 2.4 or
>>> switch to the official upstream repo?
>>
>> I don't quite understand the question. OpenBIOS is still using SVN
>> AFAIK. QEMU is using Git, so I thought we always need a Git mirror for
>> submodules? Has the git-svn integration been extended to svn submodules
>> and which versions of git support that?
>
> I'm not sure why submodules make anything different

They mean we can't literally just point our submodule at upstream,
because upstream isn't a git repo and submodules must point
at git repos. (However I think we generally prefer to point at
a git.qemu.org mirror of upstream's repo anyway.)

> , but for an SVN
> repository I can't see why the nightly cron job on git.qemu.org can't
> just run "git svn fetch && git svn rebase" directly against OpenBIOS SVN
> to update its master branch?

Sounds reasonable.

>> Unless I'm missing something, the only question is which mirror do we
>> use, not whether we use a mirror.
>
> The problem at the moment is that the repository on git.qemu.org is
> pointing to a git repository on a plain IP address (with no sensible
> reverse DNS) and so far no-one has admitted ownership. This was a
> problem last week when the repository stopped syncing with OpenBIOS SVN
> trunk and both Stefan and myself had no idea who to contact in order to
> get it fixed.

It's also an obvious problem in terms of tracability and trust
of the code we're shipping to people... We must fix this for 2.4
(or ideally ASAP) I think.

thanks
-- PMM

Re: [Qemu-devel] openbios.git mirror on git.qemu.org

[Stefan Hajnoczi]

[-- Attachment #1: Type: text/plain, Size: 2004 bytes --]

On Tue, May 19, 2015 at 09:55:12PM +0100, Peter Maydell wrote:
> On 19 May 2015 at 21:47, Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk> wrote:
> > On 19/05/15 13:55, Andreas Färber wrote:
> >
> >> Am 19.05.2015 um 12:42 schrieb Stefan Hajnoczi:
> >>> Ping.  Should we stick with an old mirror of OpenBIOS for QEMU 2.4 or
> >>> switch to the official upstream repo?
> >>
> >> I don't quite understand the question. OpenBIOS is still using SVN
> >> AFAIK. QEMU is using Git, so I thought we always need a Git mirror for
> >> submodules? Has the git-svn integration been extended to svn submodules
> >> and which versions of git support that?
> >
> > I'm not sure why submodules make anything different
> 
> They mean we can't literally just point our submodule at upstream,
> because upstream isn't a git repo and submodules must point
> at git repos. (However I think we generally prefer to point at
> a git.qemu.org mirror of upstream's repo anyway.)
> 
> > , but for an SVN
> > repository I can't see why the nightly cron job on git.qemu.org can't
> > just run "git svn fetch && git svn rebase" directly against OpenBIOS SVN
> > to update its master branch?
> 
> Sounds reasonable.
> 
> >> Unless I'm missing something, the only question is which mirror do we
> >> use, not whether we use a mirror.
> >
> > The problem at the moment is that the repository on git.qemu.org is
> > pointing to a git repository on a plain IP address (with no sensible
> > reverse DNS) and so far no-one has admitted ownership. This was a
> > problem last week when the repository stopped syncing with OpenBIOS SVN
> > trunk and both Stefan and myself had no idea who to contact in order to
> > get it fixed.
> 
> It's also an obvious problem in terms of tracability and trust
> of the code we're shipping to people... We must fix this for 2.4
> (or ideally ASAP) I think.

Okay.  I will set up a cronjob to use git-svn to grab the latest
OpenBIOS from upstream soon.

Stefan

[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]

Re: [Qemu-devel] openbios.git mirror on git.qemu.org

[Mark Cave-Ayland]

On 09/06/15 11:22, Stefan Hajnoczi wrote:
> On Tue, May 19, 2015 at 09:55:12PM +0100, Peter Maydell wrote:
>> On 19 May 2015 at 21:47, Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk> wrote:
>>> On 19/05/15 13:55, Andreas Färber wrote:
>>>
>>>> Am 19.05.2015 um 12:42 schrieb Stefan Hajnoczi:
>>>>> Ping.  Should we stick with an old mirror of OpenBIOS for QEMU 2.4 or
>>>>> switch to the official upstream repo?
>>>>
>>>> I don't quite understand the question. OpenBIOS is still using SVN
>>>> AFAIK. QEMU is using Git, so I thought we always need a Git mirror for
>>>> submodules? Has the git-svn integration been extended to svn submodules
>>>> and which versions of git support that?
>>>
>>> I'm not sure why submodules make anything different
>>
>> They mean we can't literally just point our submodule at upstream,
>> because upstream isn't a git repo and submodules must point
>> at git repos. (However I think we generally prefer to point at
>> a git.qemu.org mirror of upstream's repo anyway.)
>>
>>> , but for an SVN
>>> repository I can't see why the nightly cron job on git.qemu.org can't
>>> just run "git svn fetch && git svn rebase" directly against OpenBIOS SVN
>>> to update its master branch?
>>
>> Sounds reasonable.
>>
>>>> Unless I'm missing something, the only question is which mirror do we
>>>> use, not whether we use a mirror.
>>>
>>> The problem at the moment is that the repository on git.qemu.org is
>>> pointing to a git repository on a plain IP address (with no sensible
>>> reverse DNS) and so far no-one has admitted ownership. This was a
>>> problem last week when the repository stopped syncing with OpenBIOS SVN
>>> trunk and both Stefan and myself had no idea who to contact in order to
>>> get it fixed.
>>
>> It's also an obvious problem in terms of tracability and trust
>> of the code we're shipping to people... We must fix this for 2.4
>> (or ideally ASAP) I think.
> 
> Okay.  I will set up a cronjob to use git-svn to grab the latest
> OpenBIOS from upstream soon.

Hi Stefan,

As it's freeze coming up, I need to send an OpenBIOS pull request fairly
soon. Do you need anything from me to get this done beforehand?


ATB,

Mark.

Re: [Qemu-devel] openbios.git mirror on git.qemu.org

[Aurelien Jarno]

On 2015-06-11 23:34, Mark Cave-Ayland wrote:
> On 09/06/15 11:22, Stefan Hajnoczi wrote:
> > On Tue, May 19, 2015 at 09:55:12PM +0100, Peter Maydell wrote:
> >> On 19 May 2015 at 21:47, Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk> wrote:
> >>> On 19/05/15 13:55, Andreas Färber wrote:
> >>>
> >>>> Am 19.05.2015 um 12:42 schrieb Stefan Hajnoczi:
> >>>>> Ping.  Should we stick with an old mirror of OpenBIOS for QEMU 2.4 or
> >>>>> switch to the official upstream repo?
> >>>>
> >>>> I don't quite understand the question. OpenBIOS is still using SVN
> >>>> AFAIK. QEMU is using Git, so I thought we always need a Git mirror for
> >>>> submodules? Has the git-svn integration been extended to svn submodules
> >>>> and which versions of git support that?
> >>>
> >>> I'm not sure why submodules make anything different
> >>
> >> They mean we can't literally just point our submodule at upstream,
> >> because upstream isn't a git repo and submodules must point
> >> at git repos. (However I think we generally prefer to point at
> >> a git.qemu.org mirror of upstream's repo anyway.)
> >>
> >>> , but for an SVN
> >>> repository I can't see why the nightly cron job on git.qemu.org can't
> >>> just run "git svn fetch && git svn rebase" directly against OpenBIOS SVN
> >>> to update its master branch?
> >>
> >> Sounds reasonable.
> >>
> >>>> Unless I'm missing something, the only question is which mirror do we
> >>>> use, not whether we use a mirror.
> >>>
> >>> The problem at the moment is that the repository on git.qemu.org is
> >>> pointing to a git repository on a plain IP address (with no sensible
> >>> reverse DNS) and so far no-one has admitted ownership. This was a
> >>> problem last week when the repository stopped syncing with OpenBIOS SVN
> >>> trunk and both Stefan and myself had no idea who to contact in order to
> >>> get it fixed.
> >>
> >> It's also an obvious problem in terms of tracability and trust
> >> of the code we're shipping to people... We must fix this for 2.4
> >> (or ideally ASAP) I think.
> > 
> > Okay.  I will set up a cronjob to use git-svn to grab the latest
> > OpenBIOS from upstream soon.
> 
> Hi Stefan,
> 
> As it's freeze coming up, I need to send an OpenBIOS pull request fairly
> soon. Do you need anything from me to get this done beforehand?

For what I can see on the server, I confirm that the openbios.git
repository on git.qemu.org is point to a git server with a static IP.
Ideally we should run our own git-svn on the server.

Unfortunately the directory is owned by aliguori:aliguori so only
Anthony or an admin can probably fix that.

Aurelien

-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
aurelien@aurel32.net                 http://www.aurel32.net

Re: [Qemu-devel] openbios.git mirror on git.qemu.org

[Mark Cave-Ayland]

On 13/06/15 08:53, Aurelien Jarno wrote:

>> As it's freeze coming up, I need to send an OpenBIOS pull request fairly
>> soon. Do you need anything from me to get this done beforehand?
> 
> For what I can see on the server, I confirm that the openbios.git
> repository on git.qemu.org is point to a git server with a static IP.
> Ideally we should run our own git-svn on the server.
> 
> Unfortunately the directory is owned by aliguori:aliguori so only
> Anthony or an admin can probably fix that.

I've just done a complete OpenBIOS test run on my images here so I'm
ready to send the pull request. Should I just send it regardless or wait
for the repository switch first?


ATB,

Mark.

Re: [Qemu-devel] openbios.git mirror on git.qemu.org

[Stefan Hajnoczi]

[-- Attachment #1: Type: text/plain, Size: 1478 bytes --]

On Sat, Jun 13, 2015 at 04:02:34PM +0100, Mark Cave-Ayland wrote:
> On 13/06/15 08:53, Aurelien Jarno wrote:
> 
> >> As it's freeze coming up, I need to send an OpenBIOS pull request fairly
> >> soon. Do you need anything from me to get this done beforehand?
> > 
> > For what I can see on the server, I confirm that the openbios.git
> > repository on git.qemu.org is point to a git server with a static IP.
> > Ideally we should run our own git-svn on the server.
> > 
> > Unfortunately the directory is owned by aliguori:aliguori so only
> > Anthony or an admin can probably fix that.
> 
> I've just done a complete OpenBIOS test run on my images here so I'm
> ready to send the pull request. Should I just send it regardless or wait
> for the repository switch first?

I got confused when looking at the git mirror configuration.

git-svn is already being used to fetch OpenBIOS from:

  svn://openbios.org/openbios/trunk/openbios-devel

Please ignore the git repo with a static IP, it never gets used because
the update-openbios.sh script runs from a cronjob and pushes into the
following repo:

http://git.qemu-project.org/?p=openbios.git;a=summary

Here are the latest commits:

2015-05-12 	mcayland	SPARC32: Reduce OpenBIOS reserved space
2015-05-12 	mcayland	OFMEM: fix off-by-one calculation in available property...
2015-05-12 	mcayland	OFMEM: remove ofmem_arch_get_phys_top() implementation
...

Does this look in sync?

Stefan

[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]

Re: [Qemu-devel] openbios.git mirror on git.qemu.org

[Mark Cave-Ayland]

On 16/06/15 13:55, Stefan Hajnoczi wrote:

>> I've just done a complete OpenBIOS test run on my images here so I'm
>> ready to send the pull request. Should I just send it regardless or wait
>> for the repository switch first?
> 
> I got confused when looking at the git mirror configuration.
> 
> git-svn is already being used to fetch OpenBIOS from:
> 
>   svn://openbios.org/openbios/trunk/openbios-devel
> 
> Please ignore the git repo with a static IP, it never gets used because
> the update-openbios.sh script runs from a cronjob and pushes into the
> following repo:
> 
> http://git.qemu-project.org/?p=openbios.git;a=summary
> 
> Here are the latest commits:
> 
> 2015-05-12 	mcayland	SPARC32: Reduce OpenBIOS reserved space
> 2015-05-12 	mcayland	OFMEM: fix off-by-one calculation in available property...
> 2015-05-12 	mcayland	OFMEM: remove ofmem_arch_get_phys_top() implementation
> ...
> 
> Does this look in sync?

Yes, that's what I'd expect to see. In that case I'll get a pull request
for 2.4 sent out when I'm back from work this evening - thanks a lot for
looking into this.


ATB,

Mark.