From: Eric Blake <eblake@redhat.com>
To: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>,
qemu-devel@nongnu.org
Cc: amit.shah@redhat.com, agraf@suse.de, quintela@redhat.com
Subject: Re: [Qemu-devel] [PATCH 0/4] Add section footers to detect corrupted migration streams
Date: Tue, 19 May 2015 07:51:45 -0600 [thread overview]
Message-ID: <555B3FF1.6090205@redhat.com> (raw)
In-Reply-To: <1432034993-24431-1-git-send-email-dgilbert@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1822 bytes --]
On 05/19/2015 05:29 AM, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> Badly formatted migration streams can go undetected or produce
> misleading errors due to a lock of checking at the end of sections.
> In particular a section that adds an extra 0x00 at the end
> causes what looks like a normal end of stream and thus doesn't produce
> any errors, and something that ends in a 0x01..0x04 kind of look
> like real section headers and then fail when the section parser tries
> to figure out which section they are. This is made worse by the
> choice of 0x00..0x04 being small numbers that are particularly common
> in normal section data.
>
> This patch series adds a section footer consisting of a marker (0x7e - ~)
> followed by the section-id that was also sent in the header. If
> they mismatch then it throws an error explaining which section was
> being loaded.
Good idea. Is it redundant with the recent addition of self-describing
json that newer machine types send? Does it let us detect a corrupted
stream earlier in the process? Or is the main benefit that it gives
better error messages at the point corruption is first detected?
>
> The footers are tied to new machine types (on both pc types).
Good that you tied it to machine type, but is it enough? When we added
the optional section for giving the json representation of the stream,
we ended up having to add a knob to turn off that section, so that
backwards migration from a new qemu to an older one did not send it.
I'm wondering if we'll need to expose a knob to turn off footers, again
for the sake of backwards migration in downstream distros.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-05-19 13:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-19 11:29 [Qemu-devel] [PATCH 0/4] Add section footers to detect corrupted migration streams Dr. David Alan Gilbert (git)
2015-05-19 11:29 ` [Qemu-devel] [PATCH 1/4] Merge section header writing Dr. David Alan Gilbert (git)
2015-05-20 8:50 ` Juan Quintela
2015-05-19 11:29 ` [Qemu-devel] [PATCH 2/4] Disable section footers on older machine types Dr. David Alan Gilbert (git)
2015-05-20 8:52 ` Juan Quintela
2015-05-20 17:02 ` Dr. David Alan Gilbert
2015-05-19 11:29 ` [Qemu-devel] [PATCH 3/4] Add a protective section footer Dr. David Alan Gilbert (git)
2015-05-20 8:53 ` Juan Quintela
2015-05-19 11:29 ` [Qemu-devel] [PATCH 4/4] Teach analyze-migration.py about section footers Dr. David Alan Gilbert (git)
2015-05-19 13:51 ` Eric Blake [this message]
2015-05-19 14:06 ` [Qemu-devel] [PATCH 0/4] Add section footers to detect corrupted migration streams Dr. David Alan Gilbert
2015-05-19 14:13 ` Eric Blake
2015-05-19 14:28 ` Dr. David Alan Gilbert
2015-05-19 14:40 ` Eric Blake
2015-05-20 8:58 ` Juan Quintela
2015-05-20 7:13 ` Amit Shah
2015-05-20 7:18 ` Amit Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=555B3FF1.6090205@redhat.com \
--to=eblake@redhat.com \
--cc=agraf@suse.de \
--cc=amit.shah@redhat.com \
--cc=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).