From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58677) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YukZD-0004Bv-Oy for qemu-devel@nongnu.org; Tue, 19 May 2015 12:40:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YukZB-000252-25 for qemu-devel@nongnu.org; Tue, 19 May 2015 12:40:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43238) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YukZA-00024q-Kr for qemu-devel@nongnu.org; Tue, 19 May 2015 12:40:28 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id E610E8E3E4 for ; Tue, 19 May 2015 16:40:27 +0000 (UTC) Message-ID: <555B6777.7050006@redhat.com> Date: Tue, 19 May 2015 18:40:23 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1431352157-40283-1-git-send-email-pbonzini@redhat.com> <1431352157-40283-11-git-send-email-pbonzini@redhat.com> <87mw107coh.fsf@blackfin.pond.sub.org> In-Reply-To: <87mw107coh.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 10/31] vl: allow full-blown QemuOpts syntax for -global List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: mst@redhat.com, lersek@redhat.com, qemu-devel@nongnu.org, kraxel@redhat.com On 19/05/2015 18:30, Markus Armbruster wrote: > Restrictions on driver and property names in the shorthand syntax > driver.property=3Dvalue before the patch: >=20 > * Both are at most 63 characters long, no whitespace >=20 > * Driver name cannot contain '.' >=20 > * Property name cannot contain '=3D' >=20 > After the patch, we additionally have: >=20 > * Driver name cannot contain '=3D'. >=20 > Okay as long as no such driver name exists. Have you checked? Good catch! I now have. I've grepped for - \\..*\".*=3D.*\", - TYPE_.*\".*=3D.*\" with no hits. > Please spell out the new restriction in the commit message. Will do. >> @@ -186,6 +188,9 @@ qemu-system-i386 -global ide-drive.physical_block_= size=3D4096 -drive file=3Dfile,if=3D >> In particular, you can use this to set driver properties for devices = which are=20 >> created automatically by the machine model. To create a device which = is not=20 >> created automatically and set properties on it, use -@option{device}. >> + >> +The two syntaxes are equivalent. The longer one works for drivers wh= ose name >> +contains a dot. >> ETEXI >> =20 >> DEF("boot", HAS_ARG, QEMU_OPTION_boot, >=20 > I'd explain this as follows: >=20 > -global @var{driver}.@var{prop}=3D@var{value} is shorthand for -glo= bal > driver=3D@var{driver},property=3D@var{prop},value=3D@var{value}. T= he > longhand syntax works even when @var{driver} contains a dot. Will do. Paolo